[poppler] poppler/Annot.cc

Carlos Garcia Campos carlosgc at kemper.freedesktop.org
Fri Dec 14 03:58:27 PST 2007


 poppler/Annot.cc |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit f704e86d8c72bacbd9443c4d828cd284d3a11753
Author: Carlos Garcia Campos <carlosgc at gnome.org>
Date:   Fri Dec 14 12:58:12 2007 +0100

    Fix several crashes due to uninitialized variables in Annots.

diff --git a/poppler/Annot.cc b/poppler/Annot.cc
index 70b8409..9087b05 100644
--- a/poppler/Annot.cc
+++ b/poppler/Annot.cc
@@ -376,8 +376,9 @@ void Annot::initialize(XRef *xrefA, Dict *acroForm, Dict *dict, Catalog *catalog
   }
   obj1.free();
 
-  /* TODO: Page Object indirect reference (should be parsed ?)
-  if (dict->lookup("P", &obj1)->isDict()) {
+  /* TODO: Page Object indirect reference (should be parsed ?) */
+  pageDict = NULL;
+  /*if (dict->lookup("P", &obj1)->isDict()) {
     pageDict = NULL;
   } else {
     pageDict = NULL;
@@ -491,8 +492,10 @@ void Annot::initialize(XRef *xrefA, Dict *acroForm, Dict *dict, Catalog *catalog
   }
   obj1.free();
 
-  /* TODO: optional content should be parsed
-  if (dict->lookup("OC", &obj1)->isDict()) {
+  /* TODO: optional content should be parsed */
+  optionalContent = NULL;
+  
+  /*if (dict->lookup("OC", &obj1)->isDict()) {
     optionalContent = NULL;
   } else {
     optionalContent = NULL;


More information about the poppler mailing list