[poppler] error during compilation of cvs repository with MinGW

[Vincent Torri]

Hey,

i've just got the cvs rep of poppler and I'm trying to compile it with 
mingw (5.1.3, candidate).

I have that error:

  g++ -DHAVE_CONFIG_H -I. -I.. -I.. -I../goo 
-ID:/vincent/msys/1.0/local/include/freetype2 
-ID:/vincent/msys/1.0/local/include -ID:/vincent/msys/1.0/local/include 
-I/usr/local/include -Wall -Wno-unused -g -O2 -MT GlobalParams.lo -MD -MP 
-MF .deps/GlobalParams.Tpo -c GlobalParams.cc  -DDLL_EXPORT -DPIC -o 
.libs/GlobalParams.o
In file included from ../goo/gmem.h:13,
                  from GlobalParams.cc:27:
../poppler/poppler-config.h:146:1: warning: "CDECL" redefined
In file included from 
D:/vincent/msys/1.0/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/windows.h:48,
                  from 
D:/vincent/msys/1.0/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/rpc.h:2,
                  from 
D:/vincent/msys/1.0/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/objbase.h:3,
                  from 
D:/vincent/msys/1.0/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/ole2.h:9,
                  from 
D:/vincent/msys/1.0/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/shlobj.h:11,
                  from GlobalParams.cc:24:
D:/vincent/msys/1.0/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/windef.h:111:1: 
warning: this is the location of the previous definition
GlobalParams.cc:223: error: ISO C++ forbids declaration of `GList' with no 
type
GlobalParams.cc:223: error: expected `;' before '*' token
GlobalParams.cc: In constructor `WinFontList::WinFontList(char*)':
GlobalParams.cc:233: error: `fonts' was not declared in this scope
GlobalParams.cc:233: error: `GList' has not been declared
GlobalParams.cc: In destructor `WinFontList::~WinFontList()':
GlobalParams.cc:253: error: `fonts' was not declared in this scope
GlobalParams.cc:253: error: expected primary-expression before ')' token
GlobalParams.cc:253: error: `deleteGList' was not declared in this scope
GlobalParams.cc: In member function `void WinFontList::add(WinFontInfo*)':
GlobalParams.cc:259: error: `fonts' was not declared in this scope
GlobalParams.cc:265: error: `fonts' was not declared in this scope
GlobalParams.cc: In member function `WinFontInfo* 
WinFontList::find(GooString*)':
GlobalParams.cc:327: error: `fonts' was not declared in this scope
make[3]: *** [GlobalParams.lo] Error 1

If, for windows, glib is really needed, I think that it should be checked 
during configure. But I think that, before, one has to check if it is 
needed when poppler is compiled with MinGW.

Also, I've remarked those defines:

#ifdef WIN32
#  define strcasecmp stricmp
#endif

#ifdef WIN32
#  include <shlobj.h>
#endif

in GlobalParams.cc

With MinGW, strcasecmp is declared (in string.h) and shlobj.h is 
distributed with MinGW. Maybe those tests should be:

#ifdef _MSC_VER

instead.

regards

Vincent