[poppler] Glib bindings forms review

[Julien Rebetez]

Hi,
Sorry for the response delay.
I agree with all your points and the patch looks good though I don't 
have time right now (exams :) ) to test it.

Regards,
Julien

Carlos Garcia Campos wrote:
> Hi, 
>
> I've been reviewing forms code in the glib bindings and I think that
> current API is a little bit confusing. Having two different interfaces
> (PopplerDocument and PopplerFormfield) for handling forms doesn't look
> natural to me. So, I propose to use only one interface based on
> PopplerFormField. Instead of create structures to pass forms information
> to the frontends, we can just use an opaque object, like poppler-page,
> that wraps FormWidget. This object has methods for both getting and
> setting. Finally, in PopplerDocument we only need one method to be able
> to get a PopplerFormField from its id. 
>
> In addition, I suggest to use a PopplerFormFieldMapping, instead of
> including the coords information in the FormField object, for
> consistency with the current API (links and images). 
>
> Here is a patch that implements these suggestions:
>
> http://people.freedesktop.org/~carlosgc/poppler-glib-forms.diff
>
> what do you guys think? Julien?
>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
>