[poppler] 13 commits - fofi/FoFiType1C.cc glib/poppler-action.cc glib/poppler-document.cc glib/poppler-page.cc makefile.vc poppler/ArthurOutputDev.cc poppler/CairoOutputDev.cc poppler/CharCodeToUnicode.cc poppler/Error.cc poppler/Gfx.cc poppler/G

[Krzysztof Kowalczyk]

Right, those show the problem. However, in all the cases in XRef.cc,
we know that b is very small, so effectively those tests are
equivalent to checking for a < 0.

Regards,

-- kjk

On 9/25/07, Kristian Høgsberg <krh at bitplanet.net> wrote:
> On 9/25/07, Krzysztof Kowalczyk <kkowalczyk at gmail.com> wrote:
> > Reverted. Sorry about that and thanks for noticing and explanation.
>
> Thanks, quick response :)
>
> > I have to say that I still don't get that code. Before making this
> > change I wrote a test program (see below) that ran the expression in
> > question (a * (int) b / b != a) on every integer and would say if for
> > any int a the result is any different than just testing for a < 0.
>
> Try this one:
>
> #include <stdio.h>
>
> int main(int argc, char *argv[])
> {
>         int a = (1 << 16) + 5, b = (1 << 16) + 17;
>
>         printf("a = %d, b = %d, a * b = %d, a * b / b = %d\n",
>                a, b, a * b, a * b / b);
>
>         return 0;
> }
>
> cheers,
> Kristian
>