[poppler] [PATCH] add "const" typing to Error handling
Albert Astals Cid
aacid at kde.org
Sun Apr 20 07:03:42 PDT 2008
A Dissabte 19 Abril 2008, Kees Cook va escriure:
> This patch fixes several chunks of warnings when code uses the defined
> routines from Error.h. For example:
> SplashOutputDev.cc:1011: warning: deprecated conversion from string
> constant to 'char*' SplashOutputDev.cc:1042: warning: deprecated conversion
> from string constant to 'char*' SplashOutputDev.cc:1053: warning:
> deprecated conversion from string constant to 'char*' ...
> Please keep me in CC, I'm not subscribed to the list.
poppler code is full of those "char *" instead of "const char *" usage, we are
not patching them because it will make merging with xpdf code harder. That's
why we use -Wno-write-strings by default to not see those warnings.
So thanks for the patch but we are not accepting this patch.
More information about the poppler