[poppler] [PATCH] add "const" typing to Error handling
Albert Astals Cid
aacid at kde.org
Mon Apr 21 10:14:44 PDT 2008
A Dilluns 21 Abril 2008, Carl Worth va escriure:
> On Sun, 20 Apr 2008 16:03:42 +0200, Albert Astals Cid wrote:
> > > constant to 'char*' SplashOutputDev.cc:1042: warning: deprecated
> > > conversion from string constant to 'char*' SplashOutputDev.cc:1053:
> > > warning: deprecated conversion from string constant to 'char*' ...
> > poppler code is full of those "char *" instead of "const char *" usage,
> > we are not patching them because it will make merging with xpdf code
> > harder. That's why we use -Wno-write-strings by default to not see those
> > warnings.
> I don't follow.
> If there's a code improvement here, is there any reason not to push
> this up to the xpdf code as well?
And how do you suggest us to do this? If we could push things into xpdf,
poppler would not exist at all.
> And is "merge with xpdf" intended to be a regular activity for the
> foreseeable future?
Yes, each time the xpdf author decides to release a new xpdf version we plan
to merge the changes.
> Is there any effort to get xpdf and poppler
> unforked, (that is, to make xpdf depend on poppler)?
xpdf author was never interested in collaboration, i don't see what can have
changed over time.
More information about the poppler