[poppler] Preliminary PopplerAnnot support.

[Carlos Garcia Campos]

El mié, 30-01-2008 a las 23:57 +0100, Iñigo Martínez escribió:
> Hi:

hi Iñigo

> Here goes a patch with a preliminary support for PopplerAnnot on the
> glib bindings.
> 
> Sorry for the short comment, but I need to sleep a little.
> 
> Any review is welcome.

At a first glance I've noticed that you have implemented annots with
boxed types like actions or links. While this approach is valid for
links because they are inmutable objects, it's not valid for annots that
could be modified by clients. You need an interface back to the core
Annots to be able to change them. Have a look at how form fields are
implemented. Instead of using a boxed type, form fields are opaque
objects that provide an interface to a (core) FormWidget. 

> Good night,
> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
-- 
Carlos Garcia Campos
   elkalmail at yahoo.es
   carlosgc at gnome.org
   http://carlosgc.linups.org
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada
	digitalmente
Url : http://lists.freedesktop.org/archives/poppler/attachments/20080131/2e871ee8/attachment.pgp