[poppler] 2 commits - qt/poppler-document.cc utils/HtmlOutputDev.cc

Albert Astals Cid aacid at kemper.freedesktop.org
Sat May 31 15:12:21 PDT 2008


 qt/poppler-document.cc |    1 +
 utils/HtmlOutputDev.cc |    2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

New commits:
commit bf95c6970dacaa62512de858cf60ff6cf0c1bf7c
Author: Albert Astals Cid <aacid at kde.org>
Date:   Sun Jun 1 00:07:11 2008 +0200

    [Qt] Fix leak when calling Poppler::Document::scanForFonts

diff --git a/qt/poppler-document.cc b/qt/poppler-document.cc
index a316aa4..acecc36 100644
--- a/qt/poppler-document.cc
+++ b/qt/poppler-document.cc
@@ -142,6 +142,7 @@ bool Document::scanForFonts( int numPages, QValueList<FontInfo> *fontList ) cons
                   (Poppler::FontInfo::Type)((::FontInfo*)items->get(i))->getType());
     fontList->append(font);
   }
+  deleteGooList(items, ::FontInfo);
   return true;
 }
 
commit d21d7271fc74ab78cd157549138d0027cf179471
Author: Albert Astals Cid <aacid at kde.org>
Date:   Sat May 31 23:57:31 2008 +0200

    Make sure file exists before printing it

diff --git a/utils/HtmlOutputDev.cc b/utils/HtmlOutputDev.cc
index 1fe960f..dbcd3a6 100644
--- a/utils/HtmlOutputDev.cc
+++ b/utils/HtmlOutputDev.cc
@@ -1354,7 +1354,7 @@ GooString* HtmlOutputDev::getLinkDest(Link *link,Catalog* catalog){
 		  file->append(GooString::fromInt(page));
 	      }
 	  }
-	  if (printCommands) printf("filename %s\n",file->getCString());
+	  if (printCommands && file) printf("filename %s\n",file->getCString());
 	  return file;
 	  }
       case actionURI:


More information about the poppler mailing list