[poppler] HtmlOutputDev.cc patch: PPM images

Albert Astals Cid aacid at kde.org
Tue Sep 30 11:05:51 PDT 2008


A Dimarts 30 Setembre 2008, Warren Toomey va escriure:
> The attached patch allows pdftohtml to output non DCT images from a PDF
> document as PPM files. The program is still hard-coded to write image
> hyperlinks as ".jpg". One possible fix would be to build a GooList of
> created image filenames and use this list, but the attached patch does not
> do this.

Some comments:
 * Please send diff in unified format (diff -u) it's generally much more 
readable
 * Don't copy and paste code! If you need code from ImageOutputDev.cc create a 
file with a namespace and a function that accepts the needed parameters and 
call this function from both places, you can try to invent the names, if you 
need help i can try to suggest something.
 * Do browsers render PPM?

Thanks for the work :-)

if you want to keep working on pdftohtml i have some more bugs i can tell you 
about :D

Albert

>
> Cheers,
> 	Warren




More information about the poppler mailing list