[poppler] Poppler try to use check/radio included AP by default (pre-patch)

Albert Astals Cid aacid at kde.org
Mon Aug 17 14:07:15 PDT 2009

A Dissabte, 1 d'agost de 2009, Guillermo Antonio Amaral Bastidas va escriure:
> Hi guys,
> I wanted to submit this patch for review, it's still a little hard around
> the edges since I`m still learning the codebase but I tried to make it fit
> in as much as possible, but the idea seems solid and fixes a few bugs along
> the way. I would like to get feed back on this.
> The idea is simple, I have noticed that many Btn fields send there own APs,
> but poppler seems to want to use the dingbat instead. In some cases this
> renders a few forms useless since rendering doesn't go as planed and you
> get no visible change to the field.
> What this patch does is check if we are rendering a Btn that isn't a
> Push button, check to see if this button contains an AP dict and that
> inside that there is an N dict and use the current AS to get the propper
> reference and use that instead of rendering it by hand. If something fails,
> it drops back to the standard rendering procedure so no harm no fault.
> * I would really like to hear from anybody that knows this area of the
> code.
> An idea I had was to pre-render both AP states (maybe just the Yes/On
> state) on non push Btns missing an AP dict and/or N dict and use them on
> rendering instead of doing it when something changes. Any thoughts ?

It leaks objects when returning in the most inner if
You have ugly empty lines

As far as i understand this is 'just' a visual thing?


> Cheers and be kind :P,
> GA
> ATTACH: patch
> TEST CASE: http://downloads.guillermoamaral.com/kdab/09_r100pdf_a.pdf
> TEST CASE: http://downloads.guillermoamaral.com/kdab/01_ump_a_2009.pdf

More information about the poppler mailing list