[poppler] Poppler too slow when compiled with cms

[Carlos Garcia Campos]

El lun, 19-01-2009 a las 17:18 +0900, Koji Otani escribió:
> Hi
> I'm Koji Otani.
> 
> From: Carlos Garcia Campos <carlosgc at gnome.org>
> Subject: Re: [poppler] Poppler too slow when compiled with cms
> Date: Sun, 18 Jan 2009 18:54:51 +0100
> Message-ID: <1232301291.4868.10.camel at charmaleon>
> 
> carlosgc> El dom, 18-01-2009 a las 18:40 +0100, Carlos Garcia Campos escribió:
> carlosgc> > when compiled with cms support enabled poppler is too slow when
> carlosgc> > rendering some pages. For example, rendering page 831 of PDF
> carlosgc> > Specification 1.7 takes more than 1 minute in my system. 
> carlosgc> > 
> carlosgc> > Koji, any idea why does it happen?
> carlosgc> 
> carlosgc> btw, the output doesn't look right either. See this screenshot:
> carlosgc> 
> carlosgc> http://people.freedesktop.org/~carlosgc/poppler-with-cms.png
> carlosgc> 
> 
> Sorry, this is a bug when using cairo and CMYK Profile.
> I attach a patch to fix this.

Yes, it works, still veeeeery slow, but correctly rendered. 

Applied, thanks Koji :-)

> --------------
> Koji Otani
> documento de texto sencillo adjunto (cms-090119.patch)
> diff --git a/poppler/GfxState.cc b/poppler/GfxState.cc
> index 29d15e5..8274b5f 100644
> --- a/poppler/GfxState.cc
> +++ b/poppler/GfxState.cc
> @@ -1573,7 +1574,7 @@ void GfxICCBasedColorSpace::getRGBLine(Guchar *in, unsigned int *out,
>  	Guchar tmp[gfxColorMaxComps];
>  
>  	lineTransform->doTransform(in,tmp,1);
> -	in += 3;
> +	in += nComps;
>  	out[i] = (tmp[0] << 16) | (tmp[1] << 8) | tmp[2];
>      }
>    } else {
-- 
Carlos Garcia Campos
   elkalmail at yahoo.es
   carlosgc at gnome.org
   http://carlosgc.linups.org
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada
 digitalmente
Url : http://lists.freedesktop.org/archives/poppler/attachments/20090119/e1b3acc3/attachment.pgp