[poppler] About getFileSpecNameForPlatform

[Albert Astals Cid]

A Dimecres, 1 de juliol de 2009, Carlos Garcia Campos va escriure:
> El mar, 30-06-2009 a las 23:12 +0200, Albert Astals Cid escribió:
> > Hi, file on bug 22551 is failing on getFileSpecNameForPlatform
> >
> >   if (fileSpec->isDict()) {
> > #ifdef WIN32
> >     if (!fileSpec->dictLookup("DOS", &obj1)->isString()) {
> > #else
> >     if (!fileSpec->dictLookup("Unix", &obj1)->isString()) {
> > #endif
> >       obj1.free();
> >       if (fileSpec->dictLookup("UF", &obj1)->isString ()) {
> >         name = obj1.getString()->copy();
> >       } else if (fileSpec->dictLookup("F", &obj1)->isString ()) {
> >         name = obj1.getString()->copy();
> >       } else {
> >         error(-1, "Illegal file spec in link");
> >       }
> >     }
> >     obj1.free();
> >
> >   // error
> >   } else {
> >     error(-1, "Illegal file spec in link");
> >   }
> >
> > The thing is that i seem to miss a else here, i mean if Unix is not found
> > we use UF or F, but if Unix is found shouldn't we do
> >  name = obj1.getString()->copy();
>
> you are right.
>
> > Carlos i think this code is yours, is it a typo/bug or am i missing
> > something?
>
> Attached patch should fix the problem. It also makes that code little
> bit easier to read.

Can you fix it to include Leonard considerations?

Albert

>
> > Albert
> > _______________________________________________
> > poppler mailing list
> > poppler at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/poppler