[poppler] [PATCH] Improve getRGBLine and getGrayLine in ImageColorMap

Albert Astals Cid aacid at kde.org
Sun Jul 26 12:27:32 PDT 2009

A Diumenge, 19 de juliol de 2009, Carlos Garcia Campos va escriure:
> Hi all,
> looking at bug #11027 (getRGBLine based color space conversion can use
> bad tables) I realized that the byte_lookup table used for getLine
> methods in ImageColorMap was broken for some color spaces (Lab color
> space in the document attached to the bug report). I tried to fix the
> byte_lookup table, but I noticed that for some color spaces, like Lab,
> that don't implement getLine methods, getRGB / getGray, etc. are called
> for every pixel anyway even when getRGBLine or getGrayLine is used. For
> those cases we can just avoid allocating byte_lookup table, convert
> color values, and so on, and just directly call getRGB, getGray, etc.
> See attached patches. It fixes the problem for backends using getLine
> methods (cairo and Arthur I think)
> ok to commit?

Ok for me.


More information about the poppler mailing list