[poppler] Poppler sibling count bug (patch)

Guillermo Antonio Amaral Bastidas gamaral at amaral.com.mx
Fri Jul 31 18:43:14 PDT 2009

  Hi guys,

  I found what was going nuts with the sibling count in a few documents I
have been debugging for KDAB. 

  * The Problem: Okular never got an inaccurate sibling count on buttons so it
treated them all button widgets as separate button groups, breaking grouped
radio and check-boxes.

  * The Solution: It seems that this affected forms where most fields reside as
  children of a single field and not root.
   In short FormField::fillChildrenSiblingsID() was not propagating
  the fillChildrenSiblingsID call to it's children so it never generated the
  sibling information.

   I noticed a call to loadChildrenDefaults() but since it already gets called
  at the end of construction I'm guessing it's a mistake (tsdgeos any thoughts?)

   This fixes the problem and keeps working forms, well working.

   Please review and commit if it gets a green light.

  ATTACHED: patch
  TESTCASE: http://downloads.guillermoamaral.com/kdab/01_ump_a_2009.pdf

-------------- next part --------------
A non-text attachment was scrubbed...
Name: poppler_patch1.diff
Type: text/x-diff
Size: 344 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20090731/48ace96d/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/poppler/attachments/20090731/48ace96d/attachment.pgp 

More information about the poppler mailing list