[poppler] unit test for GLib bindings

[Kouhei Sutou]

Hi,

In <1244299332.4158.3.camel at charmaleon>
  "Re: [poppler] unit test for GLib bindings" on Sat, 06 Jun 2009 16:42:12 +0200,
  Carlos Garcia Campos <carlosgc at gnome.org> wrote:

> I've just pulled again from you repo and it still crashes with
> attachments:
> 
> $ CUTTER_DEBUG=yes glib/test/run-test.sh
> GNU gdb 6.8-debian
> Copyright (C) 2008 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "i486-linux-gnu"...
> (gdb) r
> Starting program: /home/carlos/gnome-cvs/bin/cutter --keep-opening-modules --verbose=verbose -s glib/test --exclude-directory lib --exclude-directory fixtures glib/test
> [Thread debugging using libthread_db enabled]
> [New Thread 0xb7c8d6c0 (LWP 10641)]
> test-layer:
>   test_nested:						.: (0.016063)
>   test_title:						.: (0.018539)
>   test_visible:						.: (0.001037)
> test-form-field:
>   test_multi_line_text:					.: (0.003734)
>   test_combo_choice:					.: (0.003480)
>   test_list_choice:					.: (0.005432)
>   test_check_button:					.: (0.008952)
>   test_radio_button:					.: (0.002963)
>   test_general:						.: (0.002682)
>   test_normal_text:					.: (0.002978)
>   test_file_select_text:				.: (0.003110)
>   test_push_button:					.: (0.002925)
>   test_normal_password_text:				.: (0.003063)
> test-page:
>   test_index_multi_pages:				.: (0.000797)
>   test_get_size:					.: (0.000638)
>   test_render_pixbuf:					.: (0.029454)
>   test_transition:					.: (0.000983)
>   test_index_single_page:				.: (0.000672)
>   test_get_form_field_mapping:				.: (0.002568)
>   test_get_text:					.: (0.010651)
> test-document:
>   test_attachment:					
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0xb7c8d6c0 (LWP 10641)]
> attachment_equal (data1=0x0, data2=0x8c62e00) at test-document.c:494
> 494	  if ((attachment1->checksum != attachment2->checksum) &&
> (gdb) bt
> #0  attachment_equal (data1=0x0, data2=0x8c62e00) at test-document.c:494

OK. I've added NULL check.
  http://github.com/kou/poppler-test/commit/01c2b6f6fd71718dbd0258abbbc19e7d4c0f69ac

Does the change fix the problem? (I couldn't reproduce it on
my environment.)


BTW, I've released Cutter 1.0.7. It includes a change
"including test name on crash" requested by you. :-)

If you are working on Fedora on x86_64, you can use RPM to
install Cutter:

  % wget http://downloads.sourceforge.net/cutter/cutter-1.0.7-0.x86_64.rpm
  % sudo rpm -Uvh cutter-1.0.7-0.x86_64.rpm

ref. http://cutter.sourceforge.net/reference/install-to-fedora.html


Thanks,
--
kou