[poppler] About getFileSpecNameForPlatform

Albert Astals Cid aacid at kde.org
Tue Jun 30 14:12:28 PDT 2009


Hi, file on bug 22551 is failing on getFileSpecNameForPlatform

  if (fileSpec->isDict()) {
#ifdef WIN32
    if (!fileSpec->dictLookup("DOS", &obj1)->isString()) {
#else
    if (!fileSpec->dictLookup("Unix", &obj1)->isString()) {
#endif
      obj1.free();
      if (fileSpec->dictLookup("UF", &obj1)->isString ()) {
        name = obj1.getString()->copy();
      } else if (fileSpec->dictLookup("F", &obj1)->isString ()) {
        name = obj1.getString()->copy();
      } else {
        error(-1, "Illegal file spec in link");
      }
    }
    obj1.free();

  // error
  } else {
    error(-1, "Illegal file spec in link");
  }

The thing is that i seem to miss a else here, i mean if Unix is not found we 
use UF or F, but if Unix is found shouldn't we do
 name = obj1.getString()->copy();

Carlos i think this code is yours, is it a typo/bug or am i missing something?

Albert


More information about the poppler mailing list