[poppler] Popup annotations

[Carlos Garcia Campos]

Hi all, 

Popup annots are annotations associated to a markup annotation
representing a popup window in the user interface. Right now, popup
annots are created in AnnotMarkup::initialize() taking the annot dict
from the Popup field of the annot markup dictionary. This is right,
however popup annotations are also in the main annots list which means
we are creating them again in Annots::createAnnot(), and since we are
not handling them, they are created as unknown annots. 

I'm not sure what do, I think we have at least two solutions:

 a) Handle them in Annots::createAnnot() returning NULL to ignore them.
They will be accesible through the AnnotMarkup API
AnnotMarkup::getPopup(). 

b) Handle them in Annots::createAnnot() creating a PopupAnnot and leave
frontends decide what to do with them. In this case we should probably
add refcount to popup annots, or figure out how to build the popup annot
before the markup annot and use the already created popup annot in the
markup one. 

I'm totally for a) which looks easier and clearer. 
What do you think?

-- 
Carlos Garcia Campos
   elkalmail at yahoo.es
   carlosgc at gnome.org
   http://carlosgc.linups.org
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada
 digitalmente
Url : http://lists.freedesktop.org/archives/poppler/attachments/20090506/70b71f6d/attachment.pgp