[poppler] [PATCH] Fix Splash back-end FT_Load_Glyph flags

[Benoit Jacob]

2009/10/2 Albert Astals Cid <aacid at kde.org>:
> A Dissabte, 3 d'octubre de 2009, Albert Astals Cid va escriure:
>> A Dimecres, 30 de setembre de 2009, Benoit Jacob va escriure:
>> > Further remark.
>> >
>> > If /really/ you want to keep the idea that you want to use the font's
>> > native hinting when possible and only disable auto-hinting, I just
>> > found that there is FT_LOAD_NO_AUTOHINT that does just that. So if you
>> > want to do that, just edit my function getFTLoadFlags like this:
>> >
>> > FT_Int32 SplashFTFont::getFTLoadFlags() const
>> > {
>> >  return aa ? FT_LOAD_NO_AUTOHINT | FT_LOAD_NO_BITMAP
>> >
>> >            : FT_LOAD_DEFAULT;
>> >
>> > }
>> >
>> > I'm not saying that that's a good idea. I just mention it FYI.
>> >
>> > However, before you do that, please check with the authors of the
>> > Cairo back-end as there may be a good reason why they /don't/ do that.
>> >
>> > I don't have a PDF file with fonts that do native hinting, so I can't
>> > test.
>> >
>> > My subjective opinion is : don't bother at all, as hinting seems
>> > always a bad idea to me in a PDF viewer; however I thought that I'd
>> > mention that so you know how to implement that if that's what you
>> > really want.
>>
>> The code has been there for ages, xpdf has it, so it's none of use that has
>> implemented, actually the question should be the reverse, why didn't the
>>  Cairo backend devels ask us about the flags we used?
>
> Forgot to mention we already have a way to disable autohinting provided by the
> noah flag, but it's probably wrong too since if no aa is set it passes
> FT_LOAD_DEFAULT that does autohinting.

Again: I don't really have an opinion about no-aa text. I assume that
a vast majority of people use AA, and that is also the default on all
modern systems.

>
> I'll have a look at all that code and try to find a way so everything is
> configurable so everyone can pick his poison.

Thanks for handling that!

Benoit