[poppler] [PATCH] [CMake] Preserve compile flags

Albert Astals Cid aacid at kde.org
Mon Apr 12 15:33:09 PDT 2010


A Dissabte, 10 d'abril de 2010, Maciej Mrozowski va escriure:
> From 9ba3a289672cc596d98f4b92dcfe11a61ec85124 Mon Sep 17 00:00:00 2001
> From: Maciej Mrozowski <reavertm at gmail.com>
> Date: Sat, 10 Apr 2010 04:38:47 +0200
> Subject: [PATCH] [CMake] Preserve compiler flags
> 
> - preserve GCC compiler flags passed by environment instead of replacing
> them with COMPILER_WARNINGS
> - add warnings for C compiled objects as well
> - use add_definitions() to pass preprocessor definitions instead of
> CMAKE_CXX_FLAGS

Spoke about it on IRC, the patch is rejected since it changes the default 
warning flags passed to the compiler. And that is not in your changelog, 
please make your changelog say what your patch does.

Albert


More information about the poppler mailing list