[poppler] Patches for SplashBitmap/PNGWriter

Reece Dunn msclrhd at googlemail.com
Thu Aug 19 01:36:25 PDT 2010


On 19 August 2010 09:02, Stefan Thomas <thomas at txtbear.com> wrote:
>
>> There are memory leaks in [...]
>>
>> When the writer fails to close, right?
>
> Oh yes, sorry about that! An additional delete[] row; should clean it up
> nicely.

Moving the `delete[] row;` should avoid requiring two identical lines:

      delete[] row;
+      if (!writer->close()) {
+        return splashErrGeneric;
+      }

- Reece


More information about the poppler mailing list