[poppler] Followup Bug 32349 & Poppler: More shading fun ;-)

[Thomas Freitag]

Am 29.12.2010 18:53, schrieb Andrea Canciani:
> On Wed, Dec 29, 2010 at 4:48 PM, Thomas Freitag
> <Thomas.Freitag at kabelmail.de>  wrote:
>> ...
>> I made a mistake when solving the problem with altona_visual_1v2a_x3.pdf. I
>> find now a better way to solve it, which also gives a better look of the
>> printer paper back again.
> I'd like to point yo to another pdf whose rendering regresses with the patch:
> https://bugs.freedesktop.org/attachment.cgi?id=41506
Albert, can You please just change two lines in the former patch?
1. In SplashOutputDev.cc in the constructor of SplashRadialPattern, replace
+ bitmap = new SplashBitmap(splashRound(width) + 1, splashRound(height) 
+ 1, colorMode != splashModeMono1, colorMode, gTrue);
through
+      bitmap = new SplashBitmap(splashRound(width) + 2, 
splashRound(height) + 2, colorMode != splashModeMono1, colorMode, gTrue);
2. In Splash.cc in the painting routine radialShadedFill, where the 
smaller extend circle is painted, replace
+ drawPartEllipseLine(&pipe, 2* yo - curY, xMin, xMax);
through
+                drawPartEllipseLine(&pipe, curY, xMin, xMax);
(curY is alfready recalculated two line before!)

Or just reapply the attached patch.
This solves the rendering regressions mailed by Andrea.

Thomas

> In the last row, half of the inner circle is transparent with
> poppler/master+radialsh.patch.
>
> Andrea
>
> PS: Sorry for removing most of the thread from this message, but gmail squashed
> it to just one level.
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
>
> .
>

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: radialsh.patch
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20101229/a2f80940/attachment-0001.ksh>