[poppler] [PATCH 0/5] Various fixes relating to bug #24575
David A Benjamin
davidben at MIT.EDU
Thu Jan 21 21:28:18 PST 2010
Oops. Sorry guys; forgot to set the subject.
On Fri, 22 Jan 2010, David Benjamin wrote:
> So, bug #24575 had a patch sent in that partially fixed things which was then
> incorrectly rewritten and refixed again, but that one has a suble bug left, and
> none of these really correctly fixed the stack handling, and at the end of the
> day, the PDF still doesn't render.
>
> This patchset should fix all these issues. It falls prey to the same problem of
> changing xpdf code as the original patch did, but I think the stack handling is
> worth it; this is really the right place to put the code, and the merge should
> not be too complicated in the unlikely event that xpdf ever releases again. If
> people really think it's a problem, I can personally offer to fix those merges.
>
> Hand-crafted test-cases for the last commit may be found in my Public:
>
> http://web.mit.edu/davidben/Public/poppler/
>
> David Benjamin (5):
> Avoid leaving pointers to free'd memory
> Do not use objects just after deleting them
> Maintain the height of the stack in Gfx
> Add a stack of stateGuards to Gfx
> Allow commands to abort the current stream
>
> poppler/CairoOutputDev.cc | 5 ++---
> poppler/Gfx.cc | 43 +++++++++++++++++++++++++++++++++++++++++++
> poppler/Gfx.h | 12 ++++++++++++
> poppler/GfxFont.cc | 6 ++++--
> 4 files changed, 61 insertions(+), 5 deletions(-)
>
>
More information about the poppler
mailing list