[poppler] [PATCH 0/5] Various fixes relating to bug #24575

[Albert Astals Cid]

A Divendres, 22 de gener de 2010, David A Benjamin va escriure:
> Oops. Sorry guys; forgot to set the subject.

I've applied the changes and ran my test suite, found the following:

It fixes http://bugs.freedesktop.org/show_bug.cgi?id=26248

It changes the rendering of http://bugs.freedesktop.org/show_bug.cgi?id=6688 
but can't tell if better or worse, we render different than Adobe Reader	

It changes rendering of pages 4, 5, 8, 9, 10, 13, 17, 25, 29 of 
http://bugs.freedesktop.org/show_bug.cgi?id=10898 but can't tell if better or 
worse, we render different than Adobe Reader	(starting index at 1)

It changes rendering of pages 3, 4, 5, 14, 14 of 
http://bugs.freedesktop.org/show_bug.cgi?id=24575 i'd say it looks better but 
still different than Adobe Reader	(starting index at 1)

PDF are attached to the bugs.

Anyway just the fixing of 26248 is good enough for me, since the other 3 files 
that change are broken in old and new versions.

So if noone disagrees i'll commit the changes this afternoon.

Albert

> 
> On Fri, 22 Jan 2010, David Benjamin wrote:
> > So, bug #24575 had a patch sent in that partially fixed things which was
> > then incorrectly rewritten and refixed again, but that one has a suble
> > bug left, and none of these really correctly fixed the stack handling,
> > and at the end of the day, the PDF still doesn't render.
> >
> > This patchset should fix all these issues. It falls prey to the same
> > problem of changing xpdf code as the original patch did, but I think the
> > stack handling is worth it; this is really the right place to put the
> > code, and the merge should not be too complicated in the unlikely event
> > that xpdf ever releases again. If people really think it's a problem, I
> > can personally offer to fix those merges.
> >
> > Hand-crafted test-cases for the last commit may be found in my Public:
> >
> > http://web.mit.edu/davidben/Public/poppler/
> >
> > David Benjamin (5):
> >  Avoid leaving pointers to free'd memory
> >  Do not use objects just after deleting them
> >  Maintain the height of the stack in Gfx
> >  Add a stack of stateGuards to Gfx
> >  Allow commands to abort the current stream
> >
> > poppler/CairoOutputDev.cc |    5 ++---
> > poppler/Gfx.cc            |   43
> > +++++++++++++++++++++++++++++++++++++++++++ poppler/Gfx.h             |  
> > 12 ++++++++++++
> > poppler/GfxFont.cc        |    6 ++++--
> > 4 files changed, 61 insertions(+), 5 deletions(-)
> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
>