[poppler] pdftocairo - Updated Patches

Adrian Johnson ajohnson at redneon.com
Fri Jul 30 20:25:25 PDT 2010


On 30/07/10 04:51, Albert Astals Cid wrote:
> A Dimarts, 20 de juliol de 2010, Stefan Thomas va escriure:
>>> I disagree. My original pdftocairo patch outputted PS/PDF to one file.
>>> That is the way it is intended to work similar to pdftops. Your patch
>>> introduced a bug.
>>
>> Gotcha.
>>
>> Ok, I've used multipage as the default behavior where supported and
>> added a "-split" option for splitting into individual files.
>>
>> New patchset attached. This final version should address all feedback
>> from reviewers. Thanks again!
>
> So everyone ok with me commiting this?

I've just done some testing with the patches and found a problem with 
the generated output file name.

My original patch would, if no output file name is specified, use the 
input filename to generate the output name like what pdftops does. eg

"pdftocairo -ps foo.pdf" will create foo.ps
"pdftocairo -png foo.pdf" will create foo-001.png, foo-002.png, ...

the updated patches are doing:

"pdftocairo -ps foo.pdf" will create cairoout-001.ps
"pdftocairo -png foo.pdf" will create cairoout-001.png, 
cairoout-002.png, ...

which is not very user friendly.

Also, when generating multipage output, the "-001" should not be 
appended to the file name.


>
> Albert
>
>>
>> Cheers,
>>
>> Stefan
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler



More information about the poppler mailing list