[poppler] KMP for search

[Albert Astals Cid]

A Dimarts, 15 de juny de 2010, Johannes Buchner va escriure:
> Hi!

Hi

> I implemented the KMP search algorithm in [1] but I feel it doesn't
> get attention. Please apply [2] and test it.

You sent a mail yesterday and already complain you are being ignored?

> 
> [1] https://bugs.freedesktop.org/show_bug.cgi?id=8821
> [2] https://bugs.freedesktop.org/attachment.cgi?id=36255
> 
> To be honest, the gain is small; 

If the gain is small i'd prefer to stay with our tested code than to switch to 
something totally new.

> I find it odd that the search
> function is page-based and runs per block (sorry, I'm new to poppler).
> It strikes me that no wrapped words can ever be found.
> 
> Perhaps it would also make sense to put a '#pragma omp for' in front of
> the whole-document search? (For those not familiar with OpenMP,
> this simply parallizes the search over the available CPUs.)

I don't think depending on OpenMP is an option.

Albert

> 
> Cheers,
> Johannes