[poppler] Accessibility of PDF documents (corrected patch attached)

[Albert Astals Cid]

A Dimecres, 16 de juny de 2010, omkar va escriure:
> Dear Albert,
> 
> Please find the corrected patch for "accessibility of pdf document " and
> give your feedback.

Hi, some comments:
 * The comments like
  // One more parameter(int j) is added in the getCSStyle function by CDAC 
developer Team
   need to be removed, if each line had near it who coded it, the code will be 
twice as big and much more unreadable
 * The spacing of your patches could be better, that is 
GooString* HtmlFontAccu::getCSStyle(int i, GooString* content ,int j){
should be
+GooString* HtmlFontAccu::getCSStyle(int i, GooString* content, int j){
but that's nothing huge, i can fix it
 * You are leaking (i.e. not deleting) jStr in both HtmlFontAccu::getCSStyle 
and HtmlFontAccu::CSStyle
 * I see that the new HtmlPage::complexHtml and the old HtmlPage::dumpComplex 
are very simple, i if you reused the code instead of copying it
 * This introduces a behavioural change that is unaccetable, i understand you 
want pdftohtml to produce a different (in your opinion better) output, for 
that you'll have to introduce a new comandline option to pdftohtml (something 
like --singlehtml) or something like that

Thanks for your work :-)

Albert

> 
> Thanks & regards
> Onkar
> (for CDAC Accessibility Team)
> 
> On Wed, Jun 16, 2010 at 3:48 AM, Albert Astals Cid <aacid at kde.org> wrote:
> > A Dimarts, 15 de juny de 2010, leena chourey va escriure:
> > > Dear developers,
> > > 
> > > The poppler patch is attached related with "accessibility of pdf
> > 
> > document",
> > 
> > > please check it and give your feedback.
> > 
> > Hi, some comments:
> >  * when i apply your patch the code doesn't compile
> > 
> > /home/tsdgeos/devel/poppler/utils/HtmlFonts.cc: In member function
> > ‘GooString*
> > HtmlFontAccu::CSStyle(int, int)’:
> > /home/tsdgeos/devel/poppler/utils/HtmlFonts.cc:359: error: ‘jstr’ was not
> > declared in this scope
> > 
> > After fixing that, the code does not compile again
> > 
> > /home/tsdgeos/devel/poppler/utils/HtmlOutputDev.cc: In member function
> > ‘void
> > HtmlPage::dumpAsXML(FILE*, int)’:
> > /home/tsdgeos/devel/poppler/utils/HtmlOutputDev.cc:753: error: no
> > matching function for call to ‘HtmlFontAccu::getCSStyle(int&,
> > GooString*&)’ /home/tsdgeos/devel/poppler/utils/HtmlFonts.h:93: note:
> > candidates are: GooString* HtmlFontAccu::getCSStyle(int, int,
> > GooString*)
> > /home/tsdgeos/devel/poppler/utils/HtmlOutputDev.cc: In member function
> > ‘void
> > HtmlPage::dumpComplex(FILE*, int)’:
> > /home/tsdgeos/devel/poppler/utils/HtmlOutputDev.cc:837: error: no
> > matching function for call to ‘HtmlFontAccu::getCSStyle(int&,
> > GooString*&)’ /home/tsdgeos/devel/poppler/utils/HtmlFonts.h:93: note:
> > candidates are: GooString* HtmlFontAccu::getCSStyle(int, int,
> > GooString*)
> > 
> > 
> > So i'd appreciate a patch that builds, after that we can start speaking
> > about
> > the functionality/code quailty, etc.
> > 
> > Albert
> > 
> > > On Mon, Jun 14, 2010 at 12:44 PM, leena chourey <leenagour at gmail.com>
> > 
> > wrote:
> > > > Dear Albert,
> > > > 
> > > > Thanks for responding.
> > > > The poppler patch related with our changes will be submitted soon to
> > > > poppler developers for feedback.
> > > > 
> > > > with regards
> > > > Leena
> > > > 
> > > > On Mon, Jun 14, 2010 at 3:02 AM, Albert Astals Cid <aacid at kde.org>
> > 
> > wrote:
> > > >> A Divendres, 11 de juny de 2010, leena chourey va escriure:
> > > >> > Dear all,
> > > >> > 
> > > >> > This is in continuation to our last communication related with
> > > >> > *Accessibility of Pdf document.* As discussed last time, we have
> > > >> > now completed the first prototype version of the same and we are
> > > >> > making
> > 
> > it
> > 
> > > >> > available for your testing and valuable comments/feedback. As
> > > >> > mentioned last time, we convert the PDF file into HTML format and
> > > >> > open the same automatically in Firefox.
> > > >> > 
> > > >> > Enclosed with this email is the ReadMe file which explains the
> > > >> > steps to download, install and run this enhancement. Please try
> > > >> > out the same and give us your valuable feedback.
> > > >> > 
> > > >> > 
> > > >> > We have tested it at our end by different teams and have found
> > > >> > that
> > 
> > it
> > 
> > > >> > works well in most cases. Some places where we feel work is
> > > >> > required are
> > > >> > 
> > > >> > as follows:
> > > >> >    - Sometimes Orca in not able to read header and footer of page
> > > >> >    - Some character combinations are displayed as garbage like
> > > >> >    'ft',
> > > >> 
> > > >> 'tt'
> > > >> 
> > > >> >    - Content in table format is spoken by orca but it does not say
> > 
> > the
> > 
> > > >> row
> > > >> 
> > > >> >    and column reference. Means a user can not find out that orca
> > > >> >    is
> > > >> 
> > > >> reading
> > > >> 
> > > >> >    table content. (as orca does table reading in openoffice
> > > >> >    writer)
> > > >> > 
> > > >> > We are working on these. Waiting to hear more from all.
> > > >> 
> > > >> Quick question, do you have any patches on top of the poppler you
> > > >> use?
> > > >> 
> > > >> Albert
> > > >> 
> > > >> > With regards
> > > >> > Leena C
> > > >> 
> > > >> _______________________________________________
> > > >> poppler mailing list
> > > >> poppler at lists.freedesktop.org
> > > >> http://lists.freedesktop.org/mailman/listinfo/poppler
> > > > 
> > > > --
> > > > Leena C
> > > 
> > > Thanks & Regards