[poppler] Patch go Get PDF ID

[Albert Astals Cid]

A Dilluns, 21 de juny de 2010, srinivas adicherla va escriure:
> Hi,
> 
>     I made some changes to the recent patch. I removed the function
> setID().
> 
> 
>    Please let me know when you commit this patch.
> 
> Thanks & regards
> A Srinivas

Hi, some minor comments, just for safety

+  if (obj.isNull())
+  {
+    obj.free();
+    return NULL;
+  }    

should be

+  if (!obj.isArray())
+  {
+    obj.free();
+    return NULL;
+  }    

And you should be checking that val1 and val2 are strings too before doing 
getString().

And probably you want to call Set instead of append over permanent_id and 
update_id.

Albert