[poppler] [patch] fix qt3 detection bug

Albert Astals Cid aacid at kde.org
Sat Mar 13 04:52:55 PST 2010


A Dissabte, 13 de març de 2010, Jan Engelhardt va escriure:
> Hi!
> 
> On Saturday 2010-03-13 06:21, Albert Astals Cid wrote:
> > * I didn't write the code
> 
> The git log says you authored it

git log also says "Fixes bug 14583" and there you can see the patch was 
proposed by someone else.

> 
> commit 32637db19dd80a9b8452f86eb677b10e77290627
> Author: Albert Astals Cid <aacid at kde.org>
> Date:   Sun Mar 9 00:57:08 2008 +0100
> 
>     proper lib64 Qt detection
> 
> Or is that an artifact of having unfortunately forgotten to set
> GIT_AUTHOR_{NAME,EMAIL},

Yes

> or a migration artifact from a previous
> version control system?
> 
> >BTW i'm still waiting for a patch that applies to git master.
> 
> So are you agreeing to PKG_CHECK_MODULES being "the right thing" to do,
> or do you happen to have an alternate proposal?

I don't really have an opinion, my autotools foo is small and people never 
agrees on what is better.

Albert

> 
> 
> thanks,
> Jan
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler


More information about the poppler mailing list