[poppler] compilation error with mingw-w64

[Patrick Spendrin]

Am 18.11.2010 01:22, schrieb Patrick Spendrin:
> Am 31.10.2010 14:15, schrieb Hib Eris:
>> Hi,
>>
>> On Sun, Oct 31, 2010 at 2:05 PM, Vincent Torri <vtorri at univ-evry.fr> wrote:
>>>
>>> Hey,
>>>
>>> I have mentioned the problem on IRC must maybe it's better to report here.
>>> On Windows 64 bits, long is of size 32 bits long. Hence:
>>>
>>> strtok_r.cpp:68:29: error: cast from 'const unsigned char*' to 'long
>>> unsigned int' loses precision
>>>
>>> Using unsigned long long int is maybe better. Or using unsigned __int64.
>>
>> A better approach is the patch I have attached here. It is pretty much
>> based on the strtok_r implementation from upstream.
> 
> This approach won't work since the current one is also used for msvc -
> which has no __rawmemchr at all.
> 
> Attached patch fixes the issue for all windows compilers.

Ok, I take that all back and propose Hibs patch.
The file is MinGW only (there is a define for msvc) and if we can
shorten the added code, it is less work later.

regards,
Patrick

> 
>>
>> Cheers,
>>
>> Hib
> 
> regards,
> Patrick
> 
>>
>>
>>
>> _______________________________________________
>> poppler mailing list
>> poppler at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/poppler
> 
> 
> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler