[poppler] [patch] using external data in SplashBitmap

Albert Astals Cid aacid at kde.org
Mon Oct 25 06:08:44 PDT 2010

A Dilluns, 25 d'octubre de 2010, Vincent Torri va escriure:
> Hey,


> I have written a small patch for setting external data to the SplashBitmap
> class.

What's the use case for this?

> It's not finished yet as i have some questions (and doc is not
> added):
>   * is the coding style good ?

Seems Ok

>   * i don't think I break ABI.

You break the Splash abi, but we don't care about it.

>   * what about alpha ? Afaics, it's just allocated memory with
>     a getter, that's all.

Well, it holds the alpha information, i understand you probably want to set it 

>   * I don't know what to do if topDown is true.

Probably the same as if it is false.


More information about the poppler mailing list