[poppler] Add trimbox support to pdftops

Albert Astals Cid aacid at kde.org
Thu Oct 28 13:16:23 PDT 2010

A Dijous, 28 d'octubre de 2010, Benjamin Adler va escriure:
> Hello!
> I created a first patch to get what I need, and it *seems* to work fine.
> I'm not a C++ expert and haven't touched poppler before, so I'm prepared
> to work on the patch a little more; yes, I'll remove all the useless
> comments and debug output before sending a real patch.
> Please tell me what you think!

 * Use capital first letter for the enum values.
 * Don't call the variables cropBox since it seems it contains the "cropBox", 
call them boxToCrop or something like that
 * It also would be cool if you detected -cropbox and -crop MediaBox together 
and told the user he is wrong and needs to fix his parameters.

Overval looks ok (though please send clean patches because all that //ben 
comments just make everything much harder to read)


> cheers,
> ben

More information about the poppler mailing list