[poppler] Patch for embedding videos in to the pdf
srinivas adicherla
srinivas.adicherla at gmail.com
Fri Feb 25 03:49:23 PST 2011
Hi Albert,
I made those changes and attached a new patch file.
Thanks
A srinivas
On Fri, Feb 25, 2011 at 1:49 PM, <poppler-request at lists.freedesktop.org>wrote:
> Send poppler mailing list submissions to
> poppler at lists.freedesktop.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://lists.freedesktop.org/mailman/listinfo/poppler
> or, via email, send a message with subject or body 'help' to
> poppler-request at lists.freedesktop.org
>
> You can reach the person managing the list at
> poppler-owner at lists.freedesktop.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of poppler digest..."
>
>
> Today's Topics:
>
> 1. Re: Patch for embedding videos in to the pdf (Albert Astals Cid)
> 2. Clang/Clang++ 2.9-Trunk against Poppler Trunk (Marc J. Driftmeyer)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Fri, 25 Feb 2011 08:20:59 +0000
> From: Albert Astals Cid <aacid at kde.org>
> Subject: Re: [poppler] Patch for embedding videos in to the pdf
> To: poppler at lists.freedesktop.org
> Message-ID: <201102250820.59953.aacid at kde.org>
> Content-Type: Text/Plain; charset="us-ascii"
>
> A Divendres, 25 de febrer de 2011, srinivas adicherla va escriure:
> > Hi Albert,
> >
> > I think i got it what you are going to tell.
> >
> > Is it like I need to put
> > #ifdef ENABLE_PNG
> > #include<png.h>
> > #endif
> >
> > and along with this,
> > In my code wherever I use the functions that defined in png.h
> > library
> > I need to use the similar kind of condition to check right
> > like,
> >
> > #ifdef ENABLE_PNG
> > my code
> > #endif
> >
> > is this what you were telling?
>
> Yes. Usually you leave the function declaration there and just return error
> (i
> guess NULL in your case) if the png support is not compiled in.
>
> Albert
>
> >
> > On Fri, Feb 25, 2011 at 10:26 AM, <poppler-
> request at lists.freedesktop.org>wrote:
> > > Send poppler mailing list submissions to
> > >
> > > poppler at lists.freedesktop.org
> > >
> > > To subscribe or unsubscribe via the World Wide Web, visit
> > >
> > > http://lists.freedesktop.org/mailman/listinfo/poppler
> > >
> > > or, via email, send a message with subject or body 'help' to
> > >
> > > poppler-request at lists.freedesktop.org
> > >
> > > You can reach the person managing the list at
> > >
> > > poppler-owner at lists.freedesktop.org
> > >
> > > When replying, please edit your Subject line so it is more specific
> > > than "Re: Contents of poppler digest..."
> > >
> > > Today's Topics:
> > > 1. Re: Patch for embedding videos in to the pdf (srinivas adicherla)
> > >
> > > ----------------------------------------------------------------------
> > >
> > > Message: 1
> > > Date: Fri, 25 Feb 2011 10:26:02 +0530
> > > From: srinivas adicherla <srinivas.adicherla at gmail.com>
> > > Subject: Re: [poppler] Patch for embedding videos in to the pdf
> > > To: poppler at lists.freedesktop.org
> > >
> > > Message-ID:
> > > <AANLkTik4Lst6pnJy24Z3Dq8SnfvczR+ziH3cwCnRK=qc at mail.gmail.com>
> > >
> > > Content-Type: text/plain; charset="iso-8859-1"
> > >
> > > Hi Albert,
> > >
> > > Yes, My code will not compile if png.h is not there.
> > >
> > > Thanks
> > > A Srinivas
> > >
> > > On Fri, Feb 25, 2011 at 1:30 AM, <
> poppler-request at lists.freedesktop.org
> > >
> > > >wrote:
> > > > Send poppler mailing list submissions to
> > > >
> > > > poppler at lists.freedesktop.org
> > > >
> > > > To subscribe or unsubscribe via the World Wide Web, visit
> > > >
> > > > http://lists.freedesktop.org/mailman/listinfo/poppler
> > > >
> > > > or, via email, send a message with subject or body 'help' to
> > > >
> > > > poppler-request at lists.freedesktop.org
> > > >
> > > > You can reach the person managing the list at
> > > >
> > > > poppler-owner at lists.freedesktop.org
> > > >
> > > > When replying, please edit your Subject line so it is more specific
> > > > than "Re: Contents of poppler digest..."
> > > >
> > > > Today's Topics:
> > > > 1. poppler/GfxFont.cc (Albert Astals Cid)
> > > > 2. Branch 'poppler-0.16' - poppler/GfxFont.cc (Albert Astals Cid)
> > > > 3. Re: Patch for embedding videos in to the pdf (Albert Astals Cid)
> > > >
> > > >
> ----------------------------------------------------------------------
> > > >
> > > > Message: 1
> > > > Date: Thu, 24 Feb 2011 10:45:05 -0800 (PST)
> > > > From: aacid at kemper.freedesktop.org (Albert Astals Cid)
> > > > Subject: [poppler] poppler/GfxFont.cc
> > > > To: poppler at lists.freedesktop.org
> > > > Message-ID: <20110224184505.24C9410050 at kemper.freedesktop.org>
> > > >
> > > > poppler/GfxFont.cc | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > New commits:
> > > > commit 3590a2d38082fc705040cdb31bf0b22ff12dd3e4
> > > > Author: Adrian Johnson <ajohnson at redneon.com>
> > > > Date: Thu Feb 24 18:47:35 2011 +0000
> > > >
> > > > Fix rendering of some substituted fonts
> > > >
> > > > More info in bug 34522
> > > >
> > > > diff --git a/poppler/GfxFont.cc b/poppler/GfxFont.cc
> > > > index 0a165a6..d80208d 100644
> > > > --- a/poppler/GfxFont.cc
> > > > +++ b/poppler/GfxFont.cc
> > > > @@ -23,6 +23,7 @@
> > > >
> > > > // Copyright (C) 2009 Peter Kerzum <kerzum at yandex-team.ru>
> > > > // Copyright (C) 2009, 2010 David Benjamin <davidben at mit.edu>
> > > > // Copyright (C) 2011 Axel Str?bing <axel.struebing at freenet.de>
> > > >
> > > > +// Copyright (C) 2011 Adrian Johnson <ajohnson at redneon.com>
> > > >
> > > > //
> > > > // To see a description of the changes please see the Changelog file
> > >
> > > that
> > >
> > > > // came with your tarball or type make ChangeLog if you are building
> > >
> > > from
> > >
> > > > git
> > > > @@ -1215,7 +1216,7 @@ Gushort
> > > > *Gfx8BitFont::getCodeToGIDMap(FoFiTrueType *ff) {
> > > >
> > > > cmap = 0;
> > > > useMacRoman = gFalse;
> > > > useUnicode = gFalse;
> > > >
> > > > - if (hasEncoding) {
> > > > + if (hasEncoding || type == fontType1) {
> > > >
> > > > if (usesMacRomanEnc && macRomanCmap >= 0) {
> > > >
> > > > cmap = macRomanCmap;
> > > > useMacRoman = gTrue;
> > > >
> > > > ------------------------------
> > > >
> > > > Message: 2
> > > > Date: Thu, 24 Feb 2011 10:45:39 -0800 (PST)
> > > > From: aacid at kemper.freedesktop.org (Albert Astals Cid)
> > > > Subject: [poppler] Branch 'poppler-0.16' - poppler/GfxFont.cc
> > > > To: poppler at lists.freedesktop.org
> > > > Message-ID: <20110224184539.A17CE10050 at kemper.freedesktop.org>
> > > >
> > > > poppler/GfxFont.cc | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > New commits:
> > > > commit 4808b5c42f742363b51624aa4b6d02e6e6d3a30c
> > > > Author: Adrian Johnson <ajohnson at redneon.com>
> > > > Date: Thu Feb 24 18:47:35 2011 +0000
> > > >
> > > > Fix rendering of some substituted fonts
> > > >
> > > > More info in bug 34522
> > > >
> > > > diff --git a/poppler/GfxFont.cc b/poppler/GfxFont.cc
> > > > index 0a165a6..d80208d 100644
> > > > --- a/poppler/GfxFont.cc
> > > > +++ b/poppler/GfxFont.cc
> > > > @@ -23,6 +23,7 @@
> > > >
> > > > // Copyright (C) 2009 Peter Kerzum <kerzum at yandex-team.ru>
> > > > // Copyright (C) 2009, 2010 David Benjamin <davidben at mit.edu>
> > > > // Copyright (C) 2011 Axel Str?bing <axel.struebing at freenet.de>
> > > >
> > > > +// Copyright (C) 2011 Adrian Johnson <ajohnson at redneon.com>
> > > >
> > > > //
> > > > // To see a description of the changes please see the Changelog file
> > >
> > > that
> > >
> > > > // came with your tarball or type make ChangeLog if you are building
> > >
> > > from
> > >
> > > > git
> > > > @@ -1215,7 +1216,7 @@ Gushort
> > > > *Gfx8BitFont::getCodeToGIDMap(FoFiTrueType *ff) {
> > > >
> > > > cmap = 0;
> > > > useMacRoman = gFalse;
> > > > useUnicode = gFalse;
> > > >
> > > > - if (hasEncoding) {
> > > > + if (hasEncoding || type == fontType1) {
> > > >
> > > > if (usesMacRomanEnc && macRomanCmap >= 0) {
> > > >
> > > > cmap = macRomanCmap;
> > > > useMacRoman = gTrue;
> > > >
> > > > ------------------------------
> > > >
> > > > Message: 3
> > > > Date: Thu, 24 Feb 2011 18:52:58 +0000
> > > > From: Albert Astals Cid <aacid at kde.org>
> > > > Subject: Re: [poppler] Patch for embedding videos in to the pdf
> > > > To: poppler at lists.freedesktop.org
> > > > Message-ID: <201102241852.58531.aacid at kde.org>
> > > > Content-Type: Text/Plain; charset="us-ascii"
> > > >
> > > > A Dijous, 24 de febrer de 2011, srinivas adicherla va escriure:
> > > > > Hi Albert
> > > > >
> > > > > Thank you for giving me tips.
> > > > >
> > > > > I included #if defined(ENABLE_PNG)
> > > > >
> > > > > #include "PNGWriter.h"
> > > > > #endif
> > > > >
> > > > > that is what in some places you were doing.
> > > >
> > > > Your code will not compile if png.h is not there, right?
> > > >
> > > > > About Object's freeing issue. It is not setting the value at all
> if
> > >
> > > we
> > >
> > > > > free it in the function.
> > > > >
> > > > > I saw in other places also if we initialize the objects then they
> > > > > are
> > > >
> > > > not
> > > >
> > > > > freeing, but if we get some value in to the objects
> > > > > usng dict.lookup("key", &obj); then they are freeing it. This is
> what
> > > > > I found.
> > > >
> > > > Sorry, my bad both dictSet and arrayAdd do shallow copies of the
> > > > objects
> > >
> > > so
> > >
> > > > you don't need to free them.
> > > >
> > > > Albert
> > > >
> > > > > So please give me update on this.
> > > > >
> > > > > Thank you
> > > > > A Srinivas
> > > > >
> > > > > On Wed, Feb 23, 2011 at 5:46 PM, <poppler-
> > > >
> > > > request at lists.freedesktop.org>wrote:
> > > > > > Send poppler mailing list submissions to
> > > > > >
> > > > > > poppler at lists.freedesktop.org
> > > > > >
> > > > > > To subscribe or unsubscribe via the World Wide Web, visit
> > > > > >
> > > > > > http://lists.freedesktop.org/mailman/listinfo/poppler
> > > > > >
> > > > > > or, via email, send a message with subject or body 'help' to
> > > > > >
> > > > > > poppler-request at lists.freedesktop.org
> > > > > >
> > > > > > You can reach the person managing the list at
> > > > > >
> > > > > > poppler-owner at lists.freedesktop.org
> > > > > >
> > > > > > When replying, please edit your Subject line so it is more
> specific
> > > > > > than "Re: Contents of poppler digest..."
> > > > > >
> > > > > > Today's Topics:
> > > > > > 1. Re: Font substitution in Poppler (Albert Astals Cid)
> > > > > > 2. Re: Patch for embedding videos in to the pdf. (srinivas
> > >
> > > adicherla)
> > >
> > >
> > > ----------------------------------------------------------------------
> > >
> > > > > > Message: 1
> > > > > > Date: Tue, 22 Feb 2011 20:23:44 +0000
> > > > > > From: Albert Astals Cid <aacid at kde.org>
> > > > > > Subject: Re: [poppler] Font substitution in Poppler
> > > > > > To: poppler at lists.freedesktop.org
> > > > > > Message-ID: <201102222023.44914.aacid at kde.org>
> > > > > > Content-Type: Text/Plain; charset="iso-8859-1"
> > > > > >
> > > > > > A Dimarts, 22 de febrer de 2011, jose.aliste at gmail.com va
> escriure:
> > > > > > > Hi,
> > > > > > >
> > > > > > > while reading GlobalParams.cc in poppler directory, I've
> noticed
> > >
> > > that
> > >
> > > > > > > when substituting, we only take into account substitutions for
> a
> > > >
> > > > given
> > > >
> > > > > > > font that are ttf or pfb. So I wondered why is this so? and,
> > > > > > > what would be the path to implement support for otf
> > > > > > > substitutions?
> > > > > >
> > > > > > Before worrying about the substitution have you checked if a pdf
> > > > > > with
> > >
> > > a
> > >
> > > > > > otf font embedded renders correctly?
> > > > > >
> > > > > > Albert
> > > > > >
> > > > > > > Greetings
> > > > > > >
> > > > > > > Jos?
> > > > > > > _______________________________________________
> > > > > > > poppler mailing list
> > > > > > > poppler at lists.freedesktop.org
> > > > > > > http://lists.freedesktop.org/mailman/listinfo/poppler
> > > > > >
> > > > > > ------------------------------
> > > > > >
> > > > > > Message: 2
> > > > > > Date: Wed, 23 Feb 2011 17:46:52 +0530
> > > > > > From: srinivas adicherla <srinivas.adicherla at gmail.com>
> > > > > > Subject: Re: [poppler] Patch for embedding videos in to the pdf.
> > > > > > To: poppler at lists.freedesktop.org
> > > > > >
> > > > > > Message-ID:
> > > > > > <
> AANLkTimtinmd__D762OhdiJQ0JAnDDzTi-rxq4XtZykp at mail.gmail.co
> > > > > > m
> > > > > >
> > > > > > Content-Type: text/plain; charset="iso-8859-1"
> > > > > >
> > > > > > Hi Albert
> > > > > >
> > > > > > Thank you for your suggestions. Sorry it was long gap
> > > > > > since
> > > >
> > > > you
> > > >
> > > > > > gave those suggestions. I was so busy after that.
> > > > > >
> > > > > > - about "#include <png.h>". I don't know how to check for those
> in
> > > > > > configure/cmake files.
> > > > > > If any one can give me any ideas how to do, it will be really
> > >
> > > helpful.
> > >
> > > > I
> > > >
> > > > > > just check for #ENABLE_PNG and including it. I don't know whether
> > > > > > it
> > >
> > > is
> > >
> > > > > > right or not.
> > > > > >
> > > > > > - Other things I used valgrind for memory leaks. Still in some
> > > > > > places like "object.initDict(xref)" it is showing definitely leak
> > > > > > some
> > >
> > > bytes.
> > >
> > > > > > How to overcome those things. Not only in my code still in
> poppler
> > > >
> > > > some
> > > >
> > > > > > places it is showing leaking memory for initDict(xref) or
> > > > > > initArray(xref).
> > > > > >
> > > > > > But we cannot free those objects explicitly in our code, if we
> do
> > >
> > > like
> > >
> > > > > > that. If we delete like that that value for that dictionary key
> it
> > > > > > is
> > > >
> > > > not
> > > >
> > > > > > setting.
> > > > > >
> > > > > > So is it fine?
> > > > > >
> > > > > > Please kindly give suggestios.
> > > > > >
> > > > > > Thank you all in advance.
> > > > > >
> > > > > > --
> > > > > > A Srinivas
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Wed, Feb 16, 2011 at 1:30 AM, <
> > > >
> > > > poppler-request at lists.freedesktop.org
> > > >
> > > > > > >wrote:
> > > > > > > Send poppler mailing list submissions to
> > > > > > >
> > > > > > > poppler at lists.freedesktop.org
> > > > > > >
> > > > > > > To subscribe or unsubscribe via the World Wide Web, visit
> > > > > > >
> > > > > > > http://lists.freedesktop.org/mailman/listinfo/poppler
> > > > > > >
> > > > > > > or, via email, send a message with subject or body 'help' to
> > > > > > >
> > > > > > > poppler-request at lists.freedesktop.org
> > > > > > >
> > > > > > > You can reach the person managing the list at
> > > > > > >
> > > > > > > poppler-owner at lists.freedesktop.org
> > > > > > >
> > > > > > > When replying, please edit your Subject line so it is more
> > > > > > > specific than "Re: Contents of poppler digest..."
> > > > > > >
> > > > > > > Today's Topics:
> > > > > > > 1. Re: Patch for embedding videos in to the pdf. (Albert
> Astals
> > > >
> > > > Cid)
> > > >
> > > > > > > 2. Re: pdf import in Inkscap using poppler_glib and
> > > > > > >
> > > > > > > poppler_cairo (Albert Astals Cid)
> > > > > > >
> > > > > > > 3. Re: Patch for embedding videos in to the pdf. (Albert
> Astals
> > > >
> > > > Cid)
> > > >
> > > >
> > > >
> ----------------------------------------------------------------------
> > > >
> > > > > > > Message: 1
> > > > > > > Date: Tue, 15 Feb 2011 19:13:09 +0000
> > > > > > > From: Albert Astals Cid <aacid at kde.org>
> > > > > > > Subject: Re: [poppler] Patch for embedding videos in to the
> pdf.
> > > > > > > To: poppler at lists.freedesktop.org
> > > > > > > Message-ID: <201102151913.10014.aacid at kde.org>
> > > > > > > Content-Type: Text/Plain; charset="us-ascii"
> > > > > > >
> > > > > > > A Dimarts, 15 de febrer de 2011, srinivas adicherla va
> escriure:
> > > > > > > > Hi all,
> > > > > > >
> > > > > > > Hi
> > > > > > >
> > > > > > > > I made a patch for embedding videos into the pdf file. I
> > > >
> > > > created
> > > >
> > > > > > > > a
> > > > > > > >
> > > > > > > > Screen annotation, and add a Rendition action to it. For
> > >
> > > appearance
> > >
> > > > I
> > > >
> > > > > > > took
> > > > > > >
> > > > > > > > the image from the user (only accepting png), later I will do
> > > > > > > > for
> > > > > >
> > > > > > others
> > > > > >
> > > > > > > > also. I tested opening the embedded pdf files using Adobe and
> > >
> > > Foxit
> > >
> > > > > > > Reader
> > > > > > >
> > > > > > > > it was successfully opened for me. I tried for swf and mpg
> > > > > > > > files. I am asking the user to specify the image because
> there
> > > > > > > > are lot
> > >
> > > of
> > >
> > > > > > video
> > > > > >
> > > > > > > > formats, so its time consuming for creating an image from the
> > >
> > > video
> > >
> > > > > > frame
> > > > > >
> > > > > > > > for all types. ( May be in the future i add that or anybody
> can
> > > >
> > > > help
> > > >
> > > > > > > > me
> > > > > > >
> > > > > > > in
> > > > > > >
> > > > > > > > that).
> > > > > > > >
> > > > > > > > I added the same in bugzilla.
> > > > > > >
> > > > > > > Bad idea, don't do this. Either do it here or in the bugzilla
> but
> > >
> > > not
> > >
> > > > > > > in both.
> > > > > > > In two places just makes more difficult to follow the
> dicussion.
> > > > > > >
> > > > > > > Albert
> > > > > > >
> > > > > > > > Please give me suggestions to make this successful.
> > > > > > > >
> > > > > > > > Thanks in Advance.
> > > > > > > > A Srinivas
> > > > > > >
> > > > > > > ------------------------------
> > > > > > >
> > > > > > > Message: 2
> > > > > > > Date: Tue, 15 Feb 2011 19:23:42 +0000
> > > > > > > From: Albert Astals Cid <aacid at kde.org>
> > > > > > > Subject: Re: [poppler] pdf import in Inkscap using poppler_glib
> > > > > > > and
> > > > > > >
> > > > > > > poppler_cairo
> > > > > > >
> > > > > > > To: poppler at lists.freedesktop.org
> > > > > > > Message-ID: <201102151923.43633.aacid at kde.org>
> > > > > > > Content-Type: Text/Plain; charset="iso-8859-1"
> > > > > > >
> > > > > > > A Dimarts, 15 de febrer de 2011, Pino Toscano va escriure:
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > Alle marted? 15 febbraio 2011, the Adib ha scritto:
> > > > > > > > > currently Inkscape uses poppler internal API to read in pdf
> > > >
> > > > files.
> > > >
> > > > > > > > > Those API breaks/changes from time to time.
> > > > > > > > >
> > > > > > > > > Now I try importing pdf via poppler cairo surface and those
> > >
> > > cairo
> > >
> > > > > > > > > surface as svg backend. So far that works.
> > > > > > > > >
> > > > > > > > > But I do not have any control over the process:
> > > > > > > > > - I can not set bitmap dpi
> > > > > > > > > - I can not specify if text stays text or convert to path
> > > > > > > > > etc.
> > > > > > > > >
> > > > > > > > > Do you have any sugestions?
> > > > > > > >
> > > > > > > > What I proposed more than one year ago:
> > > > > > > >
> http://sourceforge.net/mailarchive/message.php?msg_id=24162410
> > > > > > >
> > > > > > > That'd work me too :D
> > > > > > >
> > > > > > > Also if your custom inkscape converter does not depend in
> > > > > > > inkscape
> > >
> > > i
> > >
> > > > > > > see
> > > > > >
> > > > > > no
> > > > > >
> > > > > > > reason why we could not have it inside poppler too if you
> commit
> > > > > > > to maintaining it here (this way you'd be much safer to API
> > > > > > > changes)
> > > > > > >
> > > > > > > Albert
> > > > > > >
> > > > > > >
> > > > > > > ------------------------------
> > > > > > >
> > > > > > > Message: 3
> > > > > > > Date: Tue, 15 Feb 2011 19:50:51 +0000
> > > > > > > From: Albert Astals Cid <aacid at kde.org>
> > > > > > > Subject: Re: [poppler] Patch for embedding videos in to the
> pdf.
> > > > > > > To: poppler at lists.freedesktop.org
> > > > > > > Message-ID: <201102151950.51464.aacid at kde.org>
> > > > > > > Content-Type: Text/Plain; charset="us-ascii"
> > > > > > >
> > > > > > > A Dimarts, 15 de febrer de 2011, srinivas adicherla va
> escriure:
> > > > > > > > Hi all,
> > > > > > > >
> > > > > > > > I made a patch for embedding videos into the pdf file. I
> > > >
> > > > created
> > > >
> > > > > > > > a
> > > > > > > >
> > > > > > > > Screen annotation, and add a Rendition action to it. For
> > >
> > > appearance
> > >
> > > > I
> > > >
> > > > > > > took
> > > > > > >
> > > > > > > > the image from the user (only accepting png), later I will do
> > > > > > > > for
> > > > > >
> > > > > > others
> > > > > >
> > > > > > > > also. I tested opening the embedded pdf files using Adobe and
> > >
> > > Foxit
> > >
> > > > > > > Reader
> > > > > > >
> > > > > > > > it was successfully opened for me. I tried for swf and mpg
> > > > > > > > files. I am asking the user to specify the image because
> there
> > > > > > > > are lot
> > >
> > > of
> > >
> > > > > > video
> > > > > >
> > > > > > > > formats, so its time consuming for creating an image from the
> > >
> > > video
> > >
> > > > > > frame
> > > > > >
> > > > > > > > for all types. ( May be in the future i add that or anybody
> can
> > > >
> > > > help
> > > >
> > > > > > > > me
> > > > > > >
> > > > > > > in
> > > > > > >
> > > > > > > > that).
> > > > > > > >
> > > > > > > > I added the same in bugzilla.
> > > > > > > >
> > > > > > > > Please give me suggestions to make this successful.
> > > > > > >
> > > > > > > Some quick things:
> > > > > > > * You use png.h unconditionally that is not going to work, you
> > >
> > > need
> > >
> > > > to
> > > >
> > > > > > use
> > > > > >
> > > > > > > the proper defines to see if configure/cmake found it.
> > > > > > >
> > > > > > > * FILE *f;; <- extra ;
> > > > > > > * png_structp read_png;; <- again
> > > > > > > * error(-1, "The file could not be recognized as a PNG
> file.");
> > >
> > > <--
> > >
> > > > > > > You
> > > > > > >
> > > > > > > don't
> > > > > > > close f here
> > > > > > >
> > > > > > > * You don't delete imgbuf
> > > > > > > * Wihtout having any idea png_create_info_struct seems like
> you
> > > >
> > > > should
> > > >
> > > > > > > call
> > > > > > > destroy afterwards in the structure it returns
> > > > > > >
> > > > > > > * After
> > > > > > >
> > > > > > > MemStream *imgStream = load_from_png (img_file, &imgXObj,
> > > > > > > xrefA); if (!imgStream)
> > > > > > >
> > > > > > > return gFalse;
> > > > > > >
> > > > > > > you need to free all the Obj you've allocated
> > > > > > >
> > > > > > > * I'm pretty sure
> > > > > > >
> > > > > > > annotObj.dictSet("T", obj.initString(new
> > > > > > > GooString(video_name))); annotObj.dictSet("Contents",
> > > > > > > obj.initString(new
> > > > > >
> > > > > > GooString(video_name)));
> > > > > >
> > > > > > > annotObj.dictSet("F", obj.initInt(4));
> > > > > > > is leaking memory as Object is not supposed to be reused
> > > > > > > without
> > > > > >
> > > > > > freeing
> > > > > >
> > > > > > > it
> > > > > > > first, please use valgrind to detect leaks in your code
> > > > > > >
> > > > > > > Albert
> > > > > > >
> > > > > > > > Thanks in Advance.
> > > > > > > > A Srinivas
> > > > > > >
> > > > > > > ------------------------------
> > > > > > >
> > > > > > > _______________________________________________
> > > > > > > poppler mailing list
> > > > > > > poppler at lists.freedesktop.org
> > > > > > > http://lists.freedesktop.org/mailman/listinfo/poppler
> > > > > > >
> > > > > > >
> > > > > > > End of poppler Digest, Vol 72, Issue 21
> > > > > > > ***************************************
> > > > > >
> > > > > > -------------- next part --------------
> > > > > > An HTML attachment was scrubbed...
> > > > > > URL: <
> > >
> > >
> http://lists.freedesktop.org/archives/poppler/attachments/20110223/5ee0f3
> > >
> > > > > > 1c/attachment.html
> > > > > >
> > > > > > -------------- next part --------------
> > > > > > A non-text attachment was scrubbed...
> > > > > > Name: srinivas_video_embedd.patch
> > > > > > Type: text/x-patch
> > > > > > Size: 11746 bytes
> > > > > > Desc: not available
> > > > > > URL: <
> > >
> > >
> http://lists.freedesktop.org/archives/poppler/attachments/20110223/5ee0f3
> > >
> > > > > > 1c/attachment.bin
> > > > > >
> > > > > >
> > > > > > ------------------------------
> > > > > >
> > > > > > _______________________________________________
> > > > > > poppler mailing list
> > > > > > poppler at lists.freedesktop.org
> > > > > > http://lists.freedesktop.org/mailman/listinfo/poppler
> > > > > >
> > > > > >
> > > > > > End of poppler Digest, Vol 72, Issue 29
> > > > > > ***************************************
> > > >
> > > > ------------------------------
> > > >
> > > > _______________________________________________
> > > > poppler mailing list
> > > > poppler at lists.freedesktop.org
> > > > http://lists.freedesktop.org/mailman/listinfo/poppler
> > > >
> > > >
> > > > End of poppler Digest, Vol 72, Issue 32
> > > > ***************************************
> > >
> > > -------------- next part --------------
> > > An HTML attachment was scrubbed...
> > > URL: <
> > >
> http://lists.freedesktop.org/archives/poppler/attachments/20110225/7d5c43
> > > b6/attachment.htm
> > >
> > >
> > > ------------------------------
> > >
> > > _______________________________________________
> > > poppler mailing list
> > > poppler at lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/poppler
> > >
> > >
> > > End of poppler Digest, Vol 72, Issue 33
> > > ***************************************
>
>
> ------------------------------
>
> Message: 2
> Date: Thu, 24 Feb 2011 16:31:20 -0800
> From: "Marc J. Driftmeyer" <mjd at reanimality.com>
> Subject: [poppler] Clang/Clang++ 2.9-Trunk against Poppler Trunk
> To: poppler at lists.freedesktop.org
> Message-ID: <4D66F858.4070304 at reanimality.com>
> Content-Type: text/plain; charset="utf-8"; Format="flowed"
>
> I've been testing Clang trunk against various projects and am testing
> against Poppler.
>
> It hangs on the check_fonts section of code:
>
> Here is the output:
>
> The build is extremely noisy but the fatal error section that kills the
> build is as follows:
>
> [ 74%] Building CXX object
> qt4/tests/CMakeFiles/check_fonts.dir/check_fonts.cpp.o
>
> /home/mdriftmeyer/DeveloperProjects/QtProjects/Poppler/trunk/qt4/tests/check_fonts.cpp:229:14:
> warning:
> 'scanForFonts' is deprecated [-Wdeprecated-declarations]
> doc->scanForFonts( 1, &listOfFonts2 );
> ^
>
> /home/mdriftmeyer/DeveloperProjects/QtProjects/Poppler/trunk/qt4/tests/check_fonts.cpp:237:14:
> warning:
> 'scanForFonts' is deprecated [-Wdeprecated-declarations]
> doc->scanForFonts( 1, &listOfFonts3 );
> ^
> In file included from
>
> /home/mdriftmeyer/DeveloperProjects/QtProjects/Poppler/trunk/qt4/tests/check_fonts.cpp:1:
>
> In file included from /usr/include/qt4/QtTest/QtTest:3:
> In file included from /usr/include/qt4/QtCore/QtCore:3:
> In file included from /usr/include/qt4/QtCore/qabstractanimation.h:45:
> In file included from /usr/include/qt4/QtCore/qobject.h:50:
> /usr/include/qt4/QtCore/qlist.h:732:22: error: invalid operands to
> binary expression ('Poppler::FontInfo' and
> 'Poppler::FontInfo')
> if (!(i->t() == li->t()))
> ~~~~~~ ^ ~~~~~~~
> In file included from
>
> /home/mdriftmeyer/DeveloperProjects/QtProjects/Poppler/trunk/qt4/tests/check_fonts.cpp:1:
>
> In file included from /usr/include/qt4/QtTest/QtTest:7:
> In file included from /usr/include/qt4/QtTest/qtest.h:46:
> /usr/include/qt4/QtTest/qtestcase.h:176:20: note: in instantiation of
> member function
> 'QList<Poppler::FontInfo>::operator==' requested here
> return (t1 == t2)
> ^
>
> /home/mdriftmeyer/DeveloperProjects/QtProjects/Poppler/trunk/qt4/tests/check_fonts.cpp:198:5:
> note: in
> instantiation of function template specialization
> 'QTest::qCompare<QList<Poppler::FontInfo> >' requested
> here
> QCOMPARE( listOfFonts, listOfFonts2 );
> ^
> In file included from
>
> /home/mdriftmeyer/DeveloperProjects/QtProjects/Poppler/trunk/qt4/tests/check_fonts.cpp:1:
>
> In file included from /usr/include/qt4/QtTest/QtTest:7:
> In file included from /usr/include/qt4/QtTest/qtest.h:46:
> /usr/include/qt4/QtTest/qtestcase.h:81:10: note: instantiated from:
> if (!QTest::qCompare(actual, expected, #actual, #expected,
> __FILE__, __LINE__))\
> ^
> In file included from
>
> /home/mdriftmeyer/DeveloperProjects/QtProjects/Poppler/trunk/qt4/tests/check_fonts.cpp:1:
>
> In file included from /usr/include/qt4/QtTest/QtTest:3:
> In file included from /usr/include/qt4/QtCore/QtCore:3:
> In file included from /usr/include/qt4/QtCore/qabstractanimation.h:45:
> In file included from /usr/include/qt4/QtCore/qobject.h:47:
> In file included from /usr/include/qt4/QtCore/qobjectdefs.h:45:
> In file included from /usr/include/qt4/QtCore/qnamespace.h:45:
> /usr/include/qt4/QtCore/qglobal.h:1886:13: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'QBool' for 1st argument
> inline bool operator==(QBool b1, bool b2) { return !b1 == !b2; }
> ^
> /usr/include/qt4/QtCore/qglobal.h:1887:13: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'bool' for 1st argument
> inline bool operator==(bool b1, QBool b2) { return !b1 == !b2; }
> ^
> /usr/include/qt4/QtCore/qglobal.h:1888:13: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'QBool' for 1st argument
> inline bool operator==(QBool b1, QBool b2) { return !b1 == !b2; }
> ^
> In file included from
>
> /home/mdriftmeyer/DeveloperProjects/QtProjects/Poppler/trunk/qt4/tests/check_fonts.cpp:1:
>
> In file included from /usr/include/qt4/QtTest/QtTest:3:
> In file included from /usr/include/qt4/QtCore/QtCore:3:
> In file included from /usr/include/qt4/QtCore/qabstractanimation.h:45:
> In file included from /usr/include/qt4/QtCore/qobject.h:48:
> In file included from /usr/include/qt4/QtCore/qstring.h:45:
> /usr/include/qt4/QtCore/qchar.h:386:13: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'QChar' for 1st argument
> inline bool operator==(QChar c1, QChar c2) { return c1.unicode() ==
> c2.unicode(); }
> ^
> In file included from
>
> /home/mdriftmeyer/DeveloperProjects/QtProjects/Poppler/trunk/qt4/tests/check_fonts.cpp:1:
>
> In file included from /usr/include/qt4/QtTest/QtTest:3:
> In file included from /usr/include/qt4/QtCore/QtCore:3:
> In file included from /usr/include/qt4/QtCore/qabstractanimation.h:45:
> In file included from /usr/include/qt4/QtCore/qobject.h:48:
> In file included from /usr/include/qt4/QtCore/qstring.h:46:
> /usr/include/qt4/QtCore/qbytearray.h:509:13: note: candidate function
> not viable: no known conversion from
> 'Poppler::FontInfo' to 'const QByteArray' for 1st argument
> inline bool operator==(const QByteArray &a1, const QByteArray &a2)
> ^
> /usr/include/qt4/QtCore/qbytearray.h:511:13: note: candidate function
> not viable: no known conversion from
> 'Poppler::FontInfo' to 'const QByteArray' for 1st argument
> inline bool operator==(const QByteArray &a1, const char *a2)
> ^
> /usr/include/qt4/QtCore/qbytearray.h:513:13: note: candidate function
> not viable: no known conversion from
> 'Poppler::FontInfo' to 'const char *' for 1st argument
> inline bool operator==(const char *a1, const QByteArray &a2)
> ^
> In file included from
>
> /home/mdriftmeyer/DeveloperProjects/QtProjects/Poppler/trunk/qt4/tests/check_fonts.cpp:1:
>
> In file included from /usr/include/qt4/QtTest/QtTest:3:
> In file included from /usr/include/qt4/QtCore/QtCore:3:
> In file included from /usr/include/qt4/QtCore/qabstractanimation.h:45:
> In file included from /usr/include/qt4/QtCore/qobject.h:48:
> /usr/include/qt4/QtCore/qstring.h:909:13: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'QString::Null' for 1st argument
> inline bool operator==(QString::Null, QString::Null) { return true; }
> ^
> /usr/include/qt4/QtCore/qstring.h:910:13: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'QString::Null' for 1st argument
> inline bool operator==(QString::Null, const QString &s) { return
> s.isNull(); }
> ^
> /usr/include/qt4/QtCore/qstring.h:911:13: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'const QString' for 1st argument
> inline bool operator==(const QString &s, QString::Null) { return
> s.isNull(); }
> ^
> /usr/include/qt4/QtCore/qstring.h:937:32: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'const char *' for 1st argument
> inline QT_ASCII_CAST_WARN bool operator==(const char *s1, const QString
> &s2)
> ^
> /usr/include/qt4/QtCore/qstring.h:950:32: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'const char *' for 1st argument
> inline QT_ASCII_CAST_WARN bool operator==(const char *s1, const
> QLatin1String &s2)
> ^
> /usr/include/qt4/QtCore/qstring.h:963:13: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'const QLatin1String' for 1st argument
> inline bool operator==(const QLatin1String &s1, const QLatin1String &s2)
> ^
> /usr/include/qt4/QtCore/qstring.h:1171:20: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'const QStringRef' for 1st argument
> Q_CORE_EXPORT bool operator==(const QStringRef &s1,const QStringRef &s2);
> ^
> /usr/include/qt4/QtCore/qstring.h:1174:20: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'const QString' for 1st argument
> Q_CORE_EXPORT bool operator==(const QString &s1,const QStringRef &s2);
> ^
> /usr/include/qt4/QtCore/qstring.h:1177:13: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'const QStringRef' for 1st argument
> inline bool operator==(const QStringRef &s1,const QString &s2)
> ^
> /usr/include/qt4/QtCore/qstring.h:1181:20: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'const QLatin1String' for 1st argument
> Q_CORE_EXPORT bool operator==(const QLatin1String &s1, const QStringRef
> &s2);
> ^
> /usr/include/qt4/QtCore/qstring.h:1184:13: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'const QStringRef' for 1st argument
> inline bool operator==(const QStringRef &s1,const QLatin1String &s2)
> ^
> /usr/include/qt4/QtCore/qstring.h:1205:32: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'const char *' for 1st argument
> inline QT_ASCII_CAST_WARN bool operator==(const char *s1, const
> QStringRef &s2)
> ^
> /usr/include/qt4/QtCore/qstring.h:1207:32: note: candidate function not
> viable: no known conversion from
> 'Poppler::FontInfo' to 'const QStringRef' for 1st argument
> inline QT_ASCII_CAST_WARN bool operator==(const QStringRef &s1, const
> char *s2)
> ^
> 2 warnings and 1 error generated.
> make[2]: *** [qt4/tests/CMakeFiles/check_fonts.dir/check_fonts.cpp.o]
> Error 1
> make[1]: *** [qt4/tests/CMakeFiles/check_fonts.dir/all] Error 2
> make: *** [all] Error 2
> mdriftmeyer at horus:~/DeveloperProjects/QtProjects/Poppler/cmake-llvm-trunk$
>
> -----------------------------------------
>
> Is this an expected outcome?
>
> Sincerely Yours,
>
> Marc J. Driftmeyer
>
> --
> Marc J. Driftmeyer
> Email :: mjd at reanimality.com <mailto:mjd at reanimality.com>
> Web :: http://www.reanimality.com
> Cell :: (509) 435-5212
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> http://lists.freedesktop.org/archives/poppler/attachments/20110224/6c334f9f/attachment.html
> >
> -------------- next part --------------
> A non-text attachment was scrubbed...
> Name: mjd.vcf
> Type: text/x-vcard
> Size: 316 bytes
> Desc: not available
> URL: <
> http://lists.freedesktop.org/archives/poppler/attachments/20110224/6c334f9f/attachment.vcf
> >
>
> ------------------------------
>
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
>
>
> End of poppler Digest, Vol 72, Issue 35
> ***************************************
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20110225/c0f7289b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: srinivas_video_embedd.patch
Type: text/x-patch
Size: 12204 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20110225/c0f7289b/attachment-0001.bin>
More information about the poppler
mailing list