[poppler] Generic PNM support

[Albert Astals Cid]

A Divendres, 31 de desembre de 2010, Pino Toscano va escriure:
> Alle venerdì 31 dicembre 2010, Albert Astals Cid ha scritto:
> > A Dijous, 30 de desembre de 2010, Pino Toscano va escriure:
> > > Hi,
> > > 
> > > currently, there's only SplashBitmap able to export to PBM/PGM/PPM.
> > > I just created a PNMWriter to provide generic export capabilities,
> > > even when not using Splash(Bitmap) directly.
> > > References:
> > > - PBM: http://netpbm.sourceforge.net/doc/pbm.html
> > > - PGM: http://netpbm.sourceforge.net/doc/pgm.html
> > > - PPM: http://netpbm.sourceforge.net/doc/ppm.html
> > > 
> > > Attached there's a small patch for pdftoppm to use the new export
> > > filter, instead of the own SplashBitmap PNM exporting method.
> > 
> > What's the benefit of this over the existing code?
> 
> The existing code is tied to SplashBitmap, so you cannot use it when
> either you don't have a SplashBitmap at hand, or you are not using
> Splash at all.
> Note the SplashBitmap code is still faster for monochrome images,
> because it just outputs their bytes instead of converting them as arg24
> and then being converted back to the proper format by the image writer.
> 
> The patch done for pdftoppm was just a quick change to ease testing the
> new image writer.

So for now it would only benefit the cpp frontend, right? I wonder if it 
makese sense to leave it live there for the moment? Or commit it to goo but do 
not change pdftoppm since it doesn't give any real benefit?

Albert