[poppler] Followup Bug 32349 & Poppler: More shading fun ;-)

[Albert Astals Cid]

A Diumenge, 23 de gener de 2011, Albert Astals Cid va escriure:
> A Diumenge, 23 de gener de 2011, Thomas Freitag va escriure:
> > Am 23.01.2011 18:12, schrieb Albert Astals Cid:
> > > A Dissabte, 15 de gener de 2011, Thomas Freitag va escriure
> > > 
> > >> The memory problems were coming still from the wrong calculation of
> > >> shading extension which I took from Gfx.cc and tried to correct, but
> > >> it still leaded to huge circles. Andrea gave me a hint of a correct
> > >> calculation of radial shading extension in cairo, and I adapated that
> > >> code piece now successfully to Splash. It seems, as if with this the
> > >> memory problems are now gone, at least I could render every PDF You
> > >> sent me in the past, and I couldn't find any regressions in the
> > >> rendering results.
> > > 
> > > I got a new regression, will send you privately the pdf file.
> > > 
> > > The question now is, you want me to try the other newest patch? Or you
> > > want to fix this "old" one?
> > 
> > Please test the newest patch. It has a completely other algorithm and as
> > I already tested, it has not this regression and hopefully no other. I
> > 'll answer the other mails in a few seconds.
> 
> Ok, i'll run the regtest on that.

Finished successfully, i'll have a look at the code tomorrow and if i don't 
find anything obviously wrong will commit it to master :-)

Albert

> 
> Albert
> 
> > Thomas
> > 
> > > Albert
> > > 
> > >> Please test this patch, sorry if I boring You sending one patch after
> > >> another,
> > >> Thomas
> > >> 
> > >> 
> > >> _______________________________________________
> > >> poppler mailing list
> > >> poppler at lists.freedesktop.org
> > >> http://lists.freedesktop.org/mailman/listinfo/poppler
> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler