[poppler] Followup Bug 32349 & Poppler: More shading fun ;-)

[Pino Toscano]

Alle martedì 25 gennaio 2011, Thomas Freitag ha scritto:
> I had only a small problem compiling it with visual studio under
> windows: the c-compiler has a problem with using std::min or
> std::max, s. i.e.
> http://heifner.blogspot.com/2008/02/stdmin-and-stdmax.html, so I
> defined
> 
> #undef MIN
> #define MIN(a, b) ((a) < (b) ? (a) : (b))
> #undef MAX
> #define MAX(a, b) ((a) > (b) ? (a) : (b))
> 
> and used MIN and MAX instead of std::min and std::max.

Please not: other being ugly, they are potentially dangerous (think 
about doing "MAX(i++, j)" with those macros).
What I did in poppler-cpp is "foo = (std::min)(i, j)", which works 
correctly with any compiler.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20110125/3e75b0c2/attachment.pgp>