[poppler] Patch for embedding videos in to the pdf

Albert Astals Cid aacid at kde.org
Tue Mar 8 14:23:07 PST 2011

A Divendres, 4 de març de 2011, srinivas adicherla va escriure:
> Hi,
>    Thank you very much for all your suggestions.
>    I added support for jpeg image also for the poster of the embedded
> video. so if user doesn't give any poster the screen is empty.
> Please give me suggestions on this.

+static MemStream* load_from_png (FILE *f, Object *imgXObj, XRef *xrefA) {

You don't seem to use xrefA, can you remove it?

+  // Extract the video name from the file uri 
+  const char *video_name = strrchr(video_file, '/');
+  video_name++;
+  Object obj1, obj2, obj3, obj4;
+  annotObj.dictSet("T", obj1.initString(new GooString(video_name))); // title

Will crash if there is no / in video_file


More information about the poppler mailing list