[poppler] Question about CurlCachedFileLoader::init

Hib Eris hib at hiberis.nl
Wed Mar 9 13:53:41 PST 2011


Hi Albert,

On Wed, Mar 9, 2011 at 1:00 AM, Albert Astals Cid <aacid at kde.org> wrote:
> A Diumenge, 30 de gener de 2011, Albert Astals Cid va escriure:
>> I see that in CurlCachedFileLoader::init we do
>>       curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &code);
>> And then never use code again. Can we just remove that line?
>
> Hib?

My aplogies to you for not replying to this earlier, it fell of my to
do list at some point. I will take a look at it this weekend. Looks
like as it is now the line could be removed, but the proper fix would
be to actually do something sane when curl returns an error code.

Hib


More information about the poppler mailing list