[poppler] [PATCH] Simplify the GCC compiler flags/warnings

Pino Toscano pino at kde.org
Sat Mar 12 08:46:07 PST 2011


currently we have (in both the build systems, of course) the option to 
enable the compiler warnings, with the following values:
- no: no CXXFLAGS added
- yes (the default): some CXXFLAGS warnings added
- kde: more CXXFLAGS added

I've done the following patch to simplify the situation a bit, making 
the warning option (--enable-compile-warnings for autotools, 
ENABLE_COMPILE_WARNINGS for cmake) a simple yes/no option:
- no (the default): the current "yes" CXXFLAGS
- yes: all the "no" CXXFLAGS plus the other current "kde" ones

The rationale is the following:
- compiling without warnings is just a no-no, could hide really huge 
- we should put as much useful warnings as possible being used 
unconditionally (eg take an useful cxxflag, make sure poppler is clean 
with it, add it to the base ones)
- it does not make any sense to enable "kde" warnings: those are 
useful... because of themselves, not because they are "used by kde"

Thoughts? May I commit it?

Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: poppler-warns.diff
Type: text/x-patch
Size: 5573 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20110312/695a6688/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20110312/695a6688/attachment.pgp>

More information about the poppler mailing list