[poppler] Question about CurlCachedFileLoader::init

Hib Eris hib at hiberis.nl
Sat Mar 12 14:20:52 PST 2011


On Sat, Mar 12, 2011 at 2:46 PM, Albert Astals Cid <aacid at kde.org> wrote:
> A Dimecres, 9 de març de 2011, Hib Eris va escriure:
>> Hi Albert,
>> On Wed, Mar 9, 2011 at 1:00 AM, Albert Astals Cid <aacid at kde.org> wrote:
>> > A Diumenge, 30 de gener de 2011, Albert Astals Cid va escriure:
>> >> I see that in CurlCachedFileLoader::init we do
>> >>       curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &code);
>> >> And then never use code again. Can we just remove that line?
>> >
>> > Hib?
>> My aplogies to you for not replying to this earlier, it fell of my to
>> do list at some point. I will take a look at it this weekend. Looks
>> like as it is now the line could be removed, but the proper fix would
>> be to actually do something sane when curl returns an error code.
> I'll be removing the line until you provide a fixed code.
> Albert

Here is a patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Check-response-code-of-libcurl-call.patch
Type: text/x-patch
Size: 1943 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20110312/b26020ca/attachment.bin>

More information about the poppler mailing list