[poppler] [PATCH] Simplify the GCC compiler flags/warnings

[Pino Toscano]

Alle sabato 12 marzo 2011, Hib Eris ha scritto:
> One remark:
> 
> case "$enable_compile_warnings" in
> +    yes)
> +      extra_cxxflags="$extra_cxxflags \
> +                      -D_XOPEN_SOURCE=600 -D_BSD_SOURCE \
> 
> The definition of  these macro's are not about warnings, but can
> cause all kinds of unix/posix definitions to be exposed in header
> files, thus changing the compiled code.

I don't think the changes should be incompatible vs the compiled version 
without them, at most the versions of some functions should be the GNU, 
BSG or XSI versions (see [1]).

[1] http://www.gnu.org/s/libc/manual/html_node/Feature-Test-Macros.html

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20110312/adc940e6/attachment.pgp>