[poppler] cpp/poppler-document.cpp cpp/poppler-embedded-file.cpp cpp/poppler-embedded-file-private.h glib/poppler-annot.cc glib/poppler-attachment.cc glib/poppler-document.cc glib/poppler-private.h poppler/Catalog.cc poppler/Catalog.h poppler/FileS...

[Leonard Rosenthol]

Should be (he says w/o looking) the Desc key in the EmbeddedFile dict.

-----Original Message-----
From: poppler-bounces+leonardr=adobe.com at lists.freedesktop.org [mailto:poppler-bounces+leonardr=adobe.com at lists.freedesktop.org] On Behalf Of Pino Toscano
Sent: Monday, May 30, 2011 2:36 AM
To: poppler at lists.freedesktop.org
Subject: Re: [poppler] cpp/poppler-document.cpp cpp/poppler-embedded-file.cpp cpp/poppler-embedded-file-private.h glib/poppler-annot.cc glib/poppler-attachment.cc glib/poppler-document.cc glib/poppler-private.h poppler/Catalog.cc poppler/Catalog.h poppler/FileS...

Alle lunedì 30 maggio 2011, Carlos Garcia Campos ha scritto:
> Excerpts from Albert Astals Cid's message of vie may 27 21:54:05 +0200
2011:
> > A Friday, May 27, 2011, Carlos Garcia Campos va escriure:
> > > b/qt4/tests/check_attachments.cpp index 2e02ec8..6405351 100644
> > > --- a/qt4/tests/check_attachments.cpp
> > > +++ b/qt4/tests/check_attachments.cpp
> > > @@ -40,7 +40,7 @@ void TestAttachments::checkAttach1()
> > > 
> > >      Poppler::EmbeddedFile *embfile = fileList.at(0);
> > >      QCOMPARE( embfile->name(), QString( "kroller.png" ) );
> > > 
> > > -    QCOMPARE( embfile->description(),
> > > QString("/home/bradh/coding/svn-vers/KDE/kdeartwork/wallpapers/kr
> > > oller.png ") ); +    QCOMPARE( embfile->description(), QString()
> > > );
> > 
> > What happened here, we are suddenly unable to extract descriptions?
> > If so i'd like this patch to be reverted as i'd like that 
> > functionality to work.
> 
> No, there shouldn't be regressions in the API with this patch. Pino?

We were using as description the keys of the EmbeddedFiles NameTree before, which is not what acroread does (and nothing says it should done like that).
Also, one FileSpec was using Description as key instead of Desc, and that is something I don't see in the specs, nor that acroread uses.

--
Pino Toscano