[poppler] [PATCH] Selection improvements

[Albert Astals Cid]

A Divendres, 7 d'octubre de 2011, jose.aliste at gmail.com vàreu escriure:
> Hi,
> 
> On Fri, Oct 7, 2011 at 7:28 AM, Andreas Becker <atayoohoo at googlemail.com> 
wrote:
> >> Not sure if you are sending and old patch again or you are a new
> >> person
> >> doing
> >> the same mistake, but we have discussed this a few times, starting a
> >> new
> >> word
> >> when the font changes is wrong.
> >> 
> >> As an example of why it is wrong your patch changes the output of
> >> pdftotext in
> >> http://wooster.hut.fi/kurssit/s88211/s88211MatlabProject.pdf
> >> from
> >> uses a channel model described in [4]
> >> to
> >> uses a channel model described in [4 ]
> > 
> > I am a new person.
> 
> I guess I am one of the old persons ;)
> 
> > If only the space after "[4" is a problem, I can fix it using the
> > variable spaceAfter (TextOutputDev.cc).
> > 
> > Another possibility is to store a GfxFont* array in TextWord, so that
> > every letter has its own font.
> > I tested this and it works fine, but the rest of poppler still acts as
> > if
> > one word had only one font. A word would have
> > a "main font" and letters with individual fonts. It is not a very clean
> > solution, but probably better
> > than starting new words.
> 
> Yeah, the problem is that this still could have some (potentially)
> other issues as the codepath used to draw the page is so different
> from the codepath used to draw the selection, and thus why I didn't
> want to change the behaviour that much as you are proposing now. Then
> I went to see how Okular handle selections but then I got sidetracker
> (as always)

I can answer this. Okular does not use poppler to draw the selections but its 
own code. This has the benefit that we provide consisten highlighting for all 
file formats.

Albert

> Greets
> 
> > _______________________________________________
> > poppler mailing list
> > poppler at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/poppler
> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler