[poppler] RFC: patch: parallel testing

[Adam Reichold]

Hello Thomas,

Am 04.12.2012 08:41, schrieb Thomas Freitag:
> Am 04.12.2012 07:45, schrieb Adam Reichold:
> Hello everyone,
> 
> I currently try to get myself acquainted with Poppler's regression
> testing framework. Because my system has a rather low single-threaded
> performance, I tried to implement parallel testing using Python's
> Queue class.
> 
> Even though poppler-regtest currently uses two processes per test
> file, rendering even and odd pages respectively, the test files
> themselves are still handled sequentially and both process are joined
> for each test file. This will yield suboptimal system utilization even
> for a small three-core system like mine.
> 
> Using the "-t/--threads N" option in the patched poppler-regtest will
> spawn N worker threads that handle all tests they can get from a
> single queue for all known tests, allowing to heavily utilize also
> large system if using a large set of test cases. But even for my
> three-core system, this brought down the time to create references for
> the complete test suite using the Splash backend from 4,5 hours to
> 2,75 hours.
>> What do You mean with "patched poppler-regtest"? There was no
>> attachment, or do I miss something?

No, this on the process level in the test driver and independent of the
your multi-threading work. There was a patch called
"parallel_testing.patch" attached, as least my mail client tells me so.

I'll just try again...

Best regards, Adam.

>> If You talk about my multi-threaded testcase, please be aware, that it
>> is still experimental, even if quite close. Here the result of my last
>> regression test last sunday evening:
> 
>> Total 1133 tests
>> 1114 tests passed (98.32%)
>> 17 tests failed (1.50%): /media/thomas/HD-PCTU3/PDF Suite/Algorithmics -
>> The Spirit of Computing, 3rd Ed.pdf (splash), /media/thomas/HD-PCTU3/PDF
>> Suite/Essentials of English Grammar - www.ielts4u.blogfa.com.pdf ...
>> 2 tests crashed (0.18%): /media/thomas/HD-PCTU3/PDF Suite/bug157090.pdf
>> (splash), /media/thomas/HD-PCTU3/PDF Suite/sinatr4c.f5.pdf (splash)
>> I'll first have a look at the crashes next weekend, then I'll continue
>> with looking at the failed tests....
> 
>> Cheers,
>> Thomas
> 
> 
> IMHO, the necessary changes seem quite small especially since a lot of
> them are connected to indentation handling. What are your thoughts on
> the utility and implementation of this?
> 
> Best regards, Adam.
>>
>>
>> _______________________________________________
>> poppler mailing list
>> poppler at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/poppler
> 
> 
> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parallel_testing.patch
Type: text/x-patch
Size: 11449 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20121204/9343bcc2/attachment-0001.bin>