[poppler] [PATCH] [CMake] Fix automagic lcms dependencies

[Albert Astals Cid]

El Dimecres, 23 de maig de 2012, a les 21:39:27, Maciej Mrozowski va escriure:
> On Wednesday 23 of May 2012 19:46:33 Albert Astals Cid wrote:
> > El Divendres, 18 de maig de 2012, a les 01:56:03, Maciej Mrozowski va
> > 
> > escriure:
> > > Hello,
> > > 
> > > When both libcms1 and libcms2 are present, liblcms2 is automatically
> > > selected with no way to override the choice. Patch adds the choice by
> > > the
> > > means of ENABLE_LCMS2 option.
> > 
> > This doesn't work if you do not have lcms2 installed but have lcms
> > installed right?
> > Because it'll go throught the first
> > if(ENABLE_LCMS2)  (because i don't have a clue if i have it or not)
> > and then fail at
> > find_package(LCMS2)
> > and then don't look for LCMS1, no?
> 
> That's... correct.
> I could fix it to match expected behaviour, but I may have a better idea,
> how about doing it the same way --enable-cms is handled:
> - if -DENABLE_CMS=lcms1 then only look for liblcms1
> - if -DENABLE_CMS=lcms2 then only look for liblcms2
> - otherwise look for lcms2, if not found, then try lcms1 as fallback

The CMake part still looks wrong, there is no way to disable it now.

Please convert the last else to elseif "auto" and add to the description that 
anyother than lcm2,1,auto disables cms usage.

Cheers,
  Albert