[poppler] [PATCHES] New annotation features, removal of objects from xref and arrays

[Albert Astals Cid]

El Dijous, 22 de març de 2012, a les 00:15:03, Fabio D'Urso va escriure:
> [PATCH 1/7] Yet new setters to AnnotFreeText
>  poppler/Annot.cc |   45 +++++++++++++++++++++++++++++++++++++++++++++
>  poppler/Annot.h  |    2 ++
>  2 files changed, 47 insertions(+), 0 deletions(-)
Commited.

> [PATCH 2/7] Basic Annot border editing support
>  poppler/Annot.cc |   23 +++++++++++++++++++++++
>  poppler/Annot.h  |    9 +++++++++
>  2 files changed, 32 insertions(+), 0 deletions(-)
Commited.

> [PATCH 3/7] Fix in AnnotMarkup's popup window handling
>  poppler/Annot.cc |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
Commited.

> [PATCH 4/7] Added XRef::removeIndirectObject
>  poppler/PDFDoc.cc |   15 ++++++++++-----
>  poppler/XRef.cc   |   15 +++++++++++++++
>  poppler/XRef.h    |    2 ++
>  3 files changed, 27 insertions(+), 5 deletions(-)
Commited.

> [PATCH 5/7] Added Array::remove (and Object::arrayRemove)
>  poppler/Array.cc |   12 ++++++++++++
>  poppler/Array.h  |    4 ++++
>  poppler/Object.h |    5 +++++
>  3 files changed, 21 insertions(+), 0 deletions(-)
Please add a return if the range is wrong and DEBUG_MEM is not defined.
Also please use a memmove instead of a for loop to move the elems to the left

> [PATCH 6/7] Basic support for Annot appearance stream removal and
> invalidation poppler/Annot.cc |  172
> ++++++++++++++++++++++++++++++++++++++---------------- poppler/Annot.h  |  
> 26 +++++++-
>  2 files changed, 145 insertions(+), 53 deletions(-)
Please add braces {} to single line if/elses

> [PATCH 7/7] Annotation removal
>  poppler/Annot.cc |   16 ++++++++++++++++
>  poppler/Annot.h  |    1 +
>  poppler/Page.cc  |   35 +++++++++++++++++++++++++++++++++++
>  poppler/Page.h   |    2 ++
>  4 files changed, 54 insertions(+), 0 deletions(-)
Same thing about braces here

To be honest i've not reviewed them in depth but since they are just adding 
new features that will only break if you try to use it (i.e. current users of 
poppler won't get crashes/misfeatures because of those patches) i don't have 
much concerns in committing your stuff :-)

Albert