[poppler] [PATCHES] New annotation features, removal of objects from xref and arrays

[Albert Astals Cid]

El Dissabte, 24 de març de 2012, a les 18:44:22, Fabio D'Urso va escriure:
> > > [PATCH 5/7] Added Array::remove (and Object::arrayRemove)
> > 
> > Please add a return if the range is wrong and DEBUG_MEM is not defined.
> > Also please use a memmove instead of a for loop to move the elems to the
> > left> 

Isn't the third parameter to the memmove missing a +1 (or better length should 
be decremented after the move)?

Albert

> > > [PATCH 6/7] Basic support for Annot appearance stream removal and
> > > invalidation poppler/Annot.cc
> > 
> > Please add braces {} to single line if/elses
> > 
> > > [PATCH 7/7] Annotation removal
> > 
> > Same thing about braces here
> 
> Thank you Albert. These are the patches with the corrections you suggested.