[poppler] [PATCHES] New annotation features, removal of objects from xref and arrays

Carlos Garcia Campos carlosgc at gnome.org
Sun May 20 03:27:52 PDT 2012


Excerpts from Fabio D'Urso's message of sáb mar 24 18:44:22 +0100 2012:
> 
> > > [PATCH 5/7] Added Array::remove (and Object::arrayRemove)
> > Please add a return if the range is wrong and DEBUG_MEM is not defined.
> > Also please use a memmove instead of a for loop to move the elems to the left
> 
> > > [PATCH 6/7] Basic support for Annot appearance stream removal and
> > > invalidation poppler/Annot.cc
> > Please add braces {} to single line if/elses
> 
> > > [PATCH 7/7] Annotation removal
> > Same thing about braces here
> Thank you Albert. These are the patches with the corrections you suggested.
> 

Why doesn't Page::removeAnnot() also remove the appearances? I've
noticed that the qt4 implementation removes the popup and appearances
manually. Appearance streams are only removed if there aren't any
other annots referencing them, but is it possible to share the same
popup by several markup annotations? What happens with all other
objects referenced by annotations? I guess they are all left in the
document, should we remove them too? like the appearances?
Maybe we could add a Annot::removeAnnotFromPage (or something like
that) so that every annotation can implement it to remove the objects
it references and not referenced by others.

Regards, 
-- 
Carlos Garcia Campos
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462


More information about the poppler mailing list