[poppler] bug in poppler-0.21.0 and patch

Peter Breitenlohner peb at mppmu.mpg.de
Mon Oct 22 02:41:41 PDT 2012


Hi,

I think you should apply the patch
===
>From be8740ad6e78c38ba20e7a3b790b9fbd052b5cb5 Mon Sep 17 00:00:00 2001
From: Peter Breitenlohner <peb at mppmu.mpg.de>
Date: Mon, 22 Oct 2012 11:34:51 +0200
Subject: [PATCH] Correct bad semantics

Negation has higher precedence than comparison

Signed-off-by: Peter Breitenlohner <peb at mppmu.mpg.de>
---
  poppler/TextOutputDev.cc |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/poppler/TextOutputDev.cc b/poppler/TextOutputDev.cc
index 2be0b42..2638c3b 100644
--- a/poppler/TextOutputDev.cc
+++ b/poppler/TextOutputDev.cc
@@ -3371,7 +3371,7 @@ void TextPage::coalesce(GBool physLayout, double fixedPitch, GBool doHTML) {
     *  so that they extend in x without hitting neighbours
     */
    for (blk1 = blkList; blk1; blk1 = blk1->next) {
-    if (!blk1->tableId >= 0) {
+    if (!(blk1->tableId >= 0)) {
        double xMax = DBL_MAX;
        double xMin = DBL_MIN;

-- 
1.7.3.1
===

because the original condition is interpreted as
   ((!(blk1->tableId)) >= 0)
which make no sense at all.

Regards
Peter Breitenlohner <peb at mppmu.mpg.de>


More information about the poppler mailing list