[poppler] 9 commits - CMakeLists.txt goo/Makefile.am goo/NetPBMWriter.cc goo/NetPBMWriter.h goo/PNGWriter.cc goo/PNGWriter.h poppler/JBIG2Stream.h poppler/Stream.h utils/HtmlOutputDev.cc utils/ImageOutputDev.cc utils/ImageOutputDev.h utils/pdfimages.1 utils/pdfimages.cc utils/pdftocairo.cc

[Adrian Johnson]

On 28/08/13 06:47, Albert Astals Cid wrote:
> El Dimecres, 28 d'agost de 2013, a les 06:33:03, Adrian Johnson va escriure:
>> On 28/08/13 03:45, Albert Astals Cid wrote:
>>> El Dilluns, 26 d'agost de 2013, a les 01:12:32, Pino Toscano va escriure:
>>>> Alle lunedì 26 agosto 2013, Adrian Johnson ha scritto:
>>>>> On 26/08/13 07:55, Albert Astals Cid wrote:
>>>>>> I think you copy/pasted the NetPBMWriter.* headears and there's too
>>>>>> many names in them, no?
>>>>>
>>>>> NetPBMWriter.h is based on a modified copy of ImageWriter.h so I
>>>>> would expect the headers stay the same.
>>>>
>>>> Isn't it basically what I did time ago as cpp/PNMWriter.{cpp,h}?
>>>
>>> Adrian?
>>
>> I don't know. I've never paid any attention to what is under cpp/*
> 
> Fair enough, can you pay attention now to that existing file, see what code is 
> better, the same or worse than the one oyu did to write PBM and if needed move 
> the cpp/ implementation to goo/ and adjust the buildsystem?

goo/NetPBMWriter accepts input in RGB, gray, or monochrome (like the
other goo image writers) while cpp/PNMWriter only takes input in RGB
then uses the selected output format to do the conversion. So
goo/NetPBMWriterversion can not be replaced by the cpp version. Also, as
cpp/poppler-image.cpp only supports writing in PNM format and is not
using the other formats in cpp/PNMWriter we can easily switch it to
using goo/NetPBMWriter. See attached patch.


> 
> Cheers,
>   Albert
> 
>>
>>> Cheers,
>>>
>>>   Albert
>>>
>>> _______________________________________________
>>> poppler mailing list
>>> poppler at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/poppler
>>
>> _______________________________________________
>> poppler mailing list
>> poppler at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/poppler
> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-cpp-poppler-image.cc-use-goo-NetPBMWriter.patch
Type: text/x-patch
Size: 6531 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20130828/2d69689a/attachment.bin>