Sun Jan 20 03:23:21 PST 2013

Am 20.01.2013 10:46, schrieb Adam Reichold:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hello,
>
> I was just testing this, trying to understand the exact implications
> for usage of Poppler's qt4 frontend. From looking at it, I can have as
> many threads in Page::renderToImage as I like as long as I don't
> change the render hints while doing so. (Leaving overprint aside for
> the moment.)
>
> This seems to work fine, but when I search the document parallel to
> that (even using different page objects and only one thread in
> Page::search), I am getting all sorts of error messages (but no
> crashes) about the file being malformed. From Thomas' comment on the
> bug report, I would infer this is a known limitation? Or should this work?
Yes, Adam, this is a known limitation at the moment. I know, that the 
bug report with over 140 comments is bad to read, but somewhere in the 
middle we decided to make in a first step only the page rendering thread 
safe. As I left yesterday as a last comment to that bug, one of the next 
steps will be to make the qt library completely thread safe. This is 
hopefully just a small task, because most of tat I had done that 
already, so we'll have it probably in the very next future.
>
> So my current working assumption is: there can any number of rendering
> threads, but all rendering has stop before something else is to be called.
Don't spend too much work waiting on all rendering threads finished. 
I.e. in Page::search we hopefully just need to use the thread safe 
version of PDFDoc::displayPage in Page::prepareTextSearch, i.e.

parentDoc->doc->displayPage( &td, index + 1, 72, 72, rotation, false, 
true, false, null, null, null, null, true);

instead of

parentDoc->doc->displayPage( &td, index + 1, 72, 72, rotation, false, 
true, false );

Cheers,
Thomas
>
> Best regards, Adam.
>
> Am 19.01.2013 17:53, schrieb Albert Astals Cid:
>> El Dissabte, 19 de gener de 2013, a les 08:44:34, Albert Astals Cid
>> va escriure:
>>> New commits: commit 8eb489c355d734a72e140ce7e32470d048362499
>>> Author: Thomas Freitag <Thomas.Freitag at alfa.de> Date:   Sat Jan
>>> 19 17:43:08 2013 +0100
>>>
>>> Make rendering thread-safe
>>>
>>> Bug #50992
>> This is quite a big of a change, we did lots of testing to make
>> sure it did not break things, but more testing is more than
>> welcome.
>>
>> Cheers, Albert _______________________________________________
>> poppler mailing list poppler at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/poppler
>>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.19 (GNU/Linux)
>
> iQEcBAEBAgAGBQJQ+7z1AAoJEPSSjE3STU344zwIAMcfUoysRd8ziw4+hxxVwU2i
> SegHjGoT7ZsEubNKtLjRXGd7xSR52LCsgE8m3rEDXb0dJWG2htJqoUzyE/J0vZRF
> kYQNWA8oYnjrB/TAKrB6RlxB1e/U//brdPcSyemaIp8dmWSTwq26Hh9bSz1qHfd9
> RUOtC8AEGBkZHUIXNczC3ppkFrWJhQflNmDWBkwKUKnnLrFdBocMPKy3649AV0X9
> h62P3Rp8lTI0e2+PXn6HkEMPiYq3GSwewl30MvTLVLLt9nuSnV06LbJLYFeYaVpV
> OzcsdKJU2cOQMqbzKntuPasg3C5dKG5j1bC+273k9ZG5gucbr/ezwr5AImqPzag=
> =SH5o
> -----END PGP SIGNATURE-----
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
>
> .
>